Skip to content
This repository was archived by the owner on Sep 16, 2023. It is now read-only.

Commit 68f6573

Browse files
samples: add lint presubmit (#21)
* changes without context autosynth cannot find the source of changes triggered by earlier changes in this repository, or by version upgrades to tools such as linters. * chore(java_templates): add lint/static analysis presubmit checks for samples * chore(java_templates): add lint/static analysis presubmit checks for samples * chore: fix trailing whitespace Source-Author: Jeff Ching <[email protected]> Source-Date: Mon Aug 17 14:29:16 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: c3caf0704f25a0c365f1c315e804a30b87c62a75 Source-Link: googleapis/synthtool@c3caf07 * chore(java_templates): stop running pmd/spotbugs checks for samples This was creating too much noise. We will revisit with other options and/or tune these checks. Source-Author: Jeff Ching <[email protected]> Source-Date: Wed Aug 19 12:26:49 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 9602086c6c5b05db77950c7f7495a2a3868f3537 Source-Link: googleapis/synthtool@9602086
1 parent c2ce5cf commit 68f6573

File tree

3 files changed

+18
-3
lines changed

3 files changed

+18
-3
lines changed

.github/workflows/samples.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
on:
2+
pull_request:
3+
name: samples
4+
jobs:
5+
lint:
6+
runs-on: ubuntu-latest
7+
steps:
8+
- uses: actions/checkout@v2
9+
- uses: actions/setup-java@v1
10+
with:
11+
java-version: 8
12+
- name: Run checkstyle
13+
run: mvn -P lint --quiet --batch-mode checkstyle:check
14+
working-directory: samples/snippets

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ If you are using Maven, add this to your pom.xml file:
2020
<dependency>
2121
<groupId>com.google.cloud</groupId>
2222
<artifactId>google-cloud-functions</artifactId>
23-
<version>0.0.0</version>
23+
<version>0.1.0</version>
2424
</dependency>
2525

2626
```

synth.metadata

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"git": {
55
"name": ".",
66
"remote": "https://github.com/googleapis/java-functions.git",
7-
"sha": "f3916eb97f1b8f3e0b3b38d48cdd0817689e6add"
7+
"sha": "c2ce5cfca5ccfb7d9676313a4ec0c0346db001d6"
88
}
99
},
1010
{
@@ -19,7 +19,7 @@
1919
"git": {
2020
"name": "synthtool",
2121
"remote": "https://github.com/googleapis/synthtool.git",
22-
"sha": "f8823dec98277a9516f2fb6fae9f58b3a59a23e1"
22+
"sha": "9602086c6c5b05db77950c7f7495a2a3868f3537"
2323
}
2424
}
2525
],
@@ -43,6 +43,7 @@
4343
".github/release-please.yml",
4444
".github/trusted-contribution.yml",
4545
".github/workflows/ci.yaml",
46+
".github/workflows/samples.yaml",
4647
".kokoro/build.bat",
4748
".kokoro/build.sh",
4849
".kokoro/coerce_logs.sh",

0 commit comments

Comments
 (0)