diff --git a/.coveragerc b/.coveragerc index bcaea1e..b1aa5f5 100644 --- a/.coveragerc +++ b/.coveragerc @@ -5,6 +5,7 @@ branch = True show_missing = True omit = google/cloud/dataflow/__init__.py + google/cloud/dataflow/gapic_version.py exclude_lines = # Re-enable the standard pragma pragma: NO COVER diff --git a/.github/.OwlBot.lock.yaml b/.github/.OwlBot.lock.yaml index 889f77d..f0f3b24 100644 --- a/.github/.OwlBot.lock.yaml +++ b/.github/.OwlBot.lock.yaml @@ -13,4 +13,4 @@ # limitations under the License. docker: image: gcr.io/cloud-devrel-public-resources/owlbot-python:latest - digest: sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 + digest: sha256:f946c75373c2b0040e8e318c5e85d0cf46bc6e61d0a01f3ef94d8de974ac6790 diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 02f17d9..2e1c40e 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "0.8.1" + ".": "0.8.2" } diff --git a/CHANGELOG.md b/CHANGELOG.md index f64032c..88eb1f0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,12 @@ # Changelog +## [0.8.2](https://github.com/googleapis/python-dataflow-client/compare/v0.8.1...v0.8.2) (2023-02-07) + + +### Bug Fixes + +* Raise not implemented error when REST transport is not supported ([#170](https://github.com/googleapis/python-dataflow-client/issues/170)) ([44651ca](https://github.com/googleapis/python-dataflow-client/commit/44651cae3c23a05c61c8bafbb0a55b141d3368a5)) + ## [0.8.1](https://github.com/googleapis/python-dataflow-client/compare/v0.8.0...v0.8.1) (2023-01-20) diff --git a/google/cloud/dataflow/gapic_version.py b/google/cloud/dataflow/gapic_version.py index 48d7dde..6523b94 100644 --- a/google/cloud/dataflow/gapic_version.py +++ b/google/cloud/dataflow/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "0.8.1" # {x-release-please-version} +__version__ = "0.8.2" # {x-release-please-version} diff --git a/google/cloud/dataflow_v1beta3/__init__.py b/google/cloud/dataflow_v1beta3/__init__.py index db7fb4f..e9a7cb1 100644 --- a/google/cloud/dataflow_v1beta3/__init__.py +++ b/google/cloud/dataflow_v1beta3/__init__.py @@ -13,7 +13,7 @@ # See the License for the specific language governing permissions and # limitations under the License. # -from google.cloud.dataflow import gapic_version as package_version +from google.cloud.dataflow_v1beta3 import gapic_version as package_version __version__ = package_version.__version__ diff --git a/google/cloud/dataflow_v1beta3/gapic_version.py b/google/cloud/dataflow_v1beta3/gapic_version.py index 48d7dde..6523b94 100644 --- a/google/cloud/dataflow_v1beta3/gapic_version.py +++ b/google/cloud/dataflow_v1beta3/gapic_version.py @@ -13,4 +13,4 @@ # See the License for the specific language governing permissions and # limitations under the License. # -__version__ = "0.8.1" # {x-release-please-version} +__version__ = "0.8.2" # {x-release-please-version} diff --git a/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py b/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py index 18eaf06..022c5d5 100644 --- a/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py +++ b/google/cloud/dataflow_v1beta3/services/jobs_v1_beta3/transports/rest.py @@ -437,8 +437,8 @@ def __call__( timeout: Optional[float] = None, metadata: Sequence[Tuple[str, str]] = (), ) -> jobs.CheckActiveJobsResponse: - raise RuntimeError( - "Cannot define a method without a valid 'google.api.http' annotation." + raise NotImplementedError( + "Method CheckActiveJobs is not available over REST transport" ) class _CreateJob(JobsV1Beta3RestStub): diff --git a/noxfile.py b/noxfile.py index e716318..95e58c5 100644 --- a/noxfile.py +++ b/noxfile.py @@ -189,9 +189,9 @@ def unit(session): def install_systemtest_dependencies(session, *constraints): # Use pre-release gRPC for system tests. - # Exclude version 1.49.0rc1 which has a known issue. - # See https://github.com/grpc/grpc/pull/30642 - session.install("--pre", "grpcio!=1.49.0rc1") + # Exclude version 1.52.0rc1 which has a known issue. + # See https://github.com/grpc/grpc/issues/32163 + session.install("--pre", "grpcio!=1.52.0rc1") session.install(*SYSTEM_TEST_STANDARD_DEPENDENCIES, *constraints) @@ -346,9 +346,7 @@ def prerelease_deps(session): unit_deps_all = UNIT_TEST_STANDARD_DEPENDENCIES + UNIT_TEST_EXTERNAL_DEPENDENCIES session.install(*unit_deps_all) system_deps_all = ( - SYSTEM_TEST_STANDARD_DEPENDENCIES - + SYSTEM_TEST_EXTERNAL_DEPENDENCIES - + SYSTEM_TEST_EXTRAS + SYSTEM_TEST_STANDARD_DEPENDENCIES + SYSTEM_TEST_EXTERNAL_DEPENDENCIES ) session.install(*system_deps_all) @@ -378,8 +376,8 @@ def prerelease_deps(session): # dependency of grpc "six", "googleapis-common-protos", - # Exclude version 1.49.0rc1 which has a known issue. See https://github.com/grpc/grpc/pull/30642 - "grpcio!=1.49.0rc1", + # Exclude version 1.52.0rc1 which has a known issue. See https://github.com/grpc/grpc/issues/32163 + "grpcio!=1.52.0rc1", "grpcio-status", "google-api-core", "proto-plus", diff --git a/samples/generated_samples/snippet_metadata_google.dataflow.v1beta3.json b/samples/generated_samples/snippet_metadata_google.dataflow.v1beta3.json index a8534ee..f723802 100644 --- a/samples/generated_samples/snippet_metadata_google.dataflow.v1beta3.json +++ b/samples/generated_samples/snippet_metadata_google.dataflow.v1beta3.json @@ -8,7 +8,7 @@ ], "language": "PYTHON", "name": "google-cloud-dataflow-client", - "version": "0.8.1" + "version": "0.8.2" }, "snippets": [ { diff --git a/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py b/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py index b10585a..26fb514 100644 --- a/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py +++ b/tests/unit/gapic/dataflow_v1beta3/test_jobs_v1_beta3.py @@ -4118,11 +4118,10 @@ def test_check_active_jobs_rest_error(): ) # Since a `google.api.http` annotation is required for using a rest transport # method, this should error. - with pytest.raises(RuntimeError) as runtime_error: + with pytest.raises(NotImplementedError) as not_implemented_error: client.check_active_jobs({}) - assert ( - "Cannot define a method without a valid 'google.api.http' annotation." - in str(runtime_error.value) + assert "Method CheckActiveJobs is not available over REST transport" in str( + not_implemented_error.value )