Skip to content

fix: put the container-type on the actual container#1342

Merged
ckbedwell merged 2 commits into
mainfrom
fix/timepoint-feedback-widget
Oct 29, 2025
Merged

fix: put the container-type on the actual container#1342
ckbedwell merged 2 commits into
mainfrom
fix/timepoint-feedback-widget

Conversation

@ckbedwell

Copy link
Copy Markdown
Contributor

Problem

The original fix for the Feedback widget was applied incorrectly.

Solution

Tear out the unnecessary containers and add it to the Time Point Explorer container.

@ckbedwell ckbedwell requested a review from a team as a code owner October 29, 2025 10:10
@ckbedwell ckbedwell requested review from VikaCep and w1kman and removed request for VikaCep October 29, 2025 10:10
@github-actions

github-actions Bot commented Oct 29, 2025

Copy link
Copy Markdown

Script size changes

Name +/- Main This PR Outcome
[487.js] = 1,717.89 kB 1,717.89 kB
[548.js] -0.04% 759.28 kB 758.98 kB
[datasource/module.js] = 24.40 kB 24.40 kB
[692.js] = 16.75 kB 16.75 kB
[663.js] = 5.83 kB 5.83 kB
[module.js] = 4.92 kB 4.92 kB

Totals

Name +/- Main This PR Outcome
[Scripts] -0.01% 2,529.07 kB 2,528.77 kB
[Non-script Assets] = 2,595.44 kB 2,595.44 kB
[All] = 5,124.52 kB 5,124.21 kB

Generated by 🚫 dangerJS against 1a6e4c6

@w1kman w1kman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏻

  • Timepoint explorer ✔️
  • Check editor ✔️

@ckbedwell ckbedwell merged commit 08c1001 into main Oct 29, 2025
23 checks passed
@ckbedwell ckbedwell deleted the fix/timepoint-feedback-widget branch October 29, 2025 10:21
@sm-release-app sm-release-app Bot mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants