Skip to content

Fix: add isDirty to setValue in checkster (check Editor v2)#1414

Merged
ckbedwell merged 2 commits into
mainfrom
fix/enable-alert-dirty-form
Nov 5, 2025
Merged

Fix: add isDirty to setValue in checkster (check Editor v2)#1414
ckbedwell merged 2 commits into
mainfrom
fix/enable-alert-dirty-form

Conversation

@ckbedwell

Copy link
Copy Markdown
Contributor

Problem

In Checkster (Check Editor v2) we have moved to using the native isDirty value when assessing if the form has changed or not. In several places we use setValue method to change the value in the form but by default this does not dirty the form.

This issue was originally noticed when simply modifying a check to enable a per-check alert.

Solution

I've gone through and added shouldDirty: true to all of the places where I believe it should dirty the form. There are a few places where I don't think it is necessary and have left them as they are, such as when we are closing and opening requests / assertions in the MultiHTTP check.

@ckbedwell ckbedwell requested a review from a team as a code owner November 5, 2025 10:33
@ckbedwell ckbedwell requested a review from w1kman November 5, 2025 10:33
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown

Script size changes

Name +/- Main This PR Outcome
[502.js] = 1,732.65 kB 1,732.65 kB
[665.js] = 936.23 kB 936.32 kB
[datasource/module.js] = 24.72 kB 24.72 kB
[692.js] = 16.80 kB 16.80 kB
[663.js] = 5.83 kB 5.83 kB
[module.js] = 4.92 kB 4.92 kB

Totals

Name +/- Main This PR Outcome
[Scripts] = 2,721.15 kB 2,721.24 kB
[Non-script Assets] = 2,613.55 kB 2,613.55 kB
[All] = 5,334.70 kB 5,334.78 kB

Generated by 🚫 dangerJS against 3741893

@ckbedwell ckbedwell merged commit 2460926 into main Nov 5, 2025
23 checks passed
@ckbedwell ckbedwell deleted the fix/enable-alert-dirty-form branch November 5, 2025 11:58
@sm-release-app sm-release-app Bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants