feat: modernize scripted and browser examples#1458
Merged
Conversation
using expect() instead of check() + fail()
Script size changes
Totals
|
ckbedwell
requested changes
Nov 13, 2025
ckbedwell
left a comment
Contributor
There was a problem hiding this comment.
Just a few updates :)
We also have to give consideration to what we give up when we encourage people to use assertions rather than checks...
Contributor
Author
|
Addressed the review comments 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1086
expect()instead ofcheck()+fail(), similar to what has been done herehttps://quickpizza.grafana.cominstead ofhttps://test.k6.io