Fix routing preview visualization#1531
Merged
Merged
Conversation
Script size changes
Totals
|
bb2c699 to
81cf5b5
Compare
Contributor
Author
|
Holding off on merging because I first want to try upgrading the |
Contributor
Author
|
The hook's fix is in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The alert routing preview feature was failing with the following error:
or
depending whether it's run with Graft or without it.
This error started appearing after the
12.3.0Grafana release. The root cause is that theuseMatchInstancesToRouteTreeshook from@grafana/alertinguses RTK-Query internally, which requires middleware to be registered in the Redux store. Plugins don't have access to configure Grafana's main Redux store, and it breaks when trying to run it.Solution
Created a custom implementation of
useMatchInstancesToRouteTreesthat bypasses the RTK-Query middleware requirement while maintaining full compatibility with the original hook.The implementation:
getBackendSrv()matchInstancesToRouteTreesfunction from@grafana/alertingto process the dataNote: This should be a temporary solution as the
grafana/alertinghook should not break because of this. The alerting team has been notified of the problem.Before:

After: