fix: normalize Loki data frames in check test button#1566
Merged
Conversation
The check test button was broken when Loki returned data frames using the new schema format (timestamp, body) instead of the old format (Time, Line). This applies the same normalization pattern from PR #1540. - Add normalizeDataFrameJSON() that reuses normalizeLokiDataFrame logic - Update useAdHocLogs to normalize frames before processing - Use LokiFieldNames enum for consistent field name references - Add tests for normalizeDataFrameJSON
Script size changes
Totals
|
ckbedwell
approved these changes
Jan 29, 2026
ckbedwell
left a comment
Contributor
There was a problem hiding this comment.
LGTM Thank you for turning this around so fast ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The check test button was broken when Loki returned data frames using the new schema format (with field names
timestampandbody) instead of the old schema format (with field namesTimeandLine). This caused the ad-hoc check logs to fail to parse, preventing users from seeing the results of their check tests.This is the same issue that was fixed for the Timepoint Explorer in PR #1540.
Solution
This PR applies the same normalization pattern from PR #1540 to the check test button's log parsing logic.
A new
normalizeDataFrameJSON()function has been added that converts old schema field names to new schema field names before processing. This function reuses the existingnormalizeLokiDataFrame()logic by convertingDataFrameJSONtoDataFrame, normalizing, and converting back. This ensures both functions use identical normalization logic and stay in sync.The
useAdHocLogshook now normalizes incoming frames before extracting log data, allowing it to handle both old and new Loki schema formats seamlessly.