BinderClientTransport instance retained post-termination if the destination AndroidComponentAddress doesn't exist

[jdcormie]

What version of gRPC-Java are you using?

latest

What is your environment?

Android/Linux

Steps to reproduce the bug

1. Call BinderChannelBuilder.forAddress() on a directAddress whose package or Service class name doesn't exist.
2. Send a request over the new Channel to activate it.
3. Observe the request fail with UNIMPLEMENTED as expected.
4. shutdown() the Channel and awaitTermination()

What did you expect to see?

No remaining Java references to Channel related resources.

What did you see instead?

Heap dump shows a strong reference to the ServiceBinding in android.app.LoadedApk#mServices (as a ServiceConnection) even after termination.

The problem is that ServiceBinding fails to call Context#unbindService() when bindService() returns false. (See b/37092557 for discussion / longstanding confusion on when to call unbindService())

[sanjaypujare]

@markb74 could you comment on this?

[markb74]

Agreed, that's an unhandled edge case in ServiceBinding.

[sanjaypujare]

Agreed, that's an unhandled edge case in ServiceBinding.

Can this be assigned to you? Unless @jdcormie is planning to work on this...