Bootstrap 3 compatibility

[miharekar]

RC1 is out and it brings a lot of changes to form elements. Maybe someone should start making this compatible?

[josevalim]

Good point @mrfoto!

All the bootstrap related configuration is in your simple form initializer, so I recommend people to start playing with different configurations in the initializer and see how that works out!

[warmwaffles]

Unfortunately I can not apply the control-label class to b.use :label, class: 'control-label'.

This is the third time Bootstrap has changed the way forms are built, and I doubt it's the last.

[carlosantoniodasilva]

I'm happy to apply any changes in SimpleForm that allow better bootstrap 3 integration, as long as they are not specific bootstrap features across our components. All bootstrap related configuration should be in the simple form bootstrap generated initializer.

[findrails]

The bootstrap generated initializer is very good - one initial thing it misses is the ability to add a class (instead of wrap_with, for instance) in the bootstrap loader. The new bootstrap changes a few things, but most could be accomplished with that. i.e.

b.use :input, class: 'form-control'

@warmwaffles - you can get your specific problem working using config.label_class in simple_form.rb. Unfortunately, it's missing a config.input_class, which again, would solve some of the bootstrap form woes.

[carlosantoniodasilva]

input_class has been proposed and not got in, but I'm all ears to talk about it back again, as it's going to ease the usage of bootstrap 3 with SimpleForm. The other possibility of adding classes with b.use has also been discussed without agreement yet, and it also needs some more rework.

Lets talk about input_class for now in #337.

[paav-o]

Yes, support for adding class in initializer would be very useful with the new Bootstrap! Meanwhile this should do the trick for single forms:

= simple_form_for(@user, :defaults => { :wrapper_html => {:class => 'form-group'}, :input_html => { :class => 'form-control' } }) do |f|
...

[warmwaffles]

I tried snooping around the code base to look at doing a pull request, but I couldn't figure out where to add it.

[johnnyshields]

A note for Boostrap 3:

Current SimpleForm classes collection_radio_buttons_input.rb and collection_check_boxes_input.rb contain a hardcoded item_wrapper_class method, e.g.:

      def item_wrapper_class
        "radio"
      end

This is conflicts with Bootstrap radio-inline and checkbox-inline classes, which must be either radio or radio-inline, but not both at the same time. Probably not a good idea to hardcode this in a non-overridable fashion regardless.

I raised this issue with Bootstrap 3: twbs/bootstrap#9067, mdo replied:

I think we'll pass on this for now. If it becomes a bigger problem we can revisit.

[AlJohri]

@warmwaffles Does config.label_class = 'control-label' not work for you?

[warmwaffles]

@AlJohri I have not tried. I will have to take a look when I get free time.

[AlJohri]

@paav-o For form-group can you not do

config.wrappers :default, :class => "input form-group"

within the simple_form.rb initializer? the only problem is that you can't set the "input_class" but you can still set the wrapper class easily. To solve the input_class problem you can use this monkey patch:

heartcombo/simple_form-bootstrap#26 (comment)

[rafaelfranca]

Could you guys try master branch?

[AlJohri]

@rafaelfranca Is the master branch Rails 4 only?

Any chance the PR can be backported to version 2.1? It would help immensely.

[carlosantoniodasilva]

@AlJohri yes.