feat: Check transaction size

Author: howjmay

packages/chain/chain.go

@@ -98,7 +98,6 @@ type ChainCore interface {
 	LatestAnchor(freshness StateFreshness) (*isc.StateAnchor, error)
 	LatestState(freshness StateFreshness) (state.State, error)
 	LatestGasCoin(freshness StateFreshness) (*coin.CoinWithRef, error)
-	LatestL1Parameters() *parameters.L1Params
 	GetCommitteeInfo() *CommitteeInfo // TODO: Review, maybe we can reorganize the CommitteeInfo structure.
 	Store() indexedstore.IndexedStore // Use LatestState whenever possible. That will work faster.
 	Processors() *processors.Config

packages/chain/cons/cons_test.go

@@ -190,11 +190,7 @@ func testConsBasic(t *testing.T, n, f int) {
 		tc.WithInput(nid, cons.NewInputMempoolProposal(reqRefs))
 		tc.WithInput(nid, cons.NewInputStateMgrProposalConfirmed())
 		tc.WithInput(nid, cons.NewInputTimeData(now))
-<<<<<<< HEAD
 		tc.WithInput(nid, cons.NewInputL1Info([]*coin.CoinWithRef{&gasCoin}, parameters.L1Default))
-=======
-		tc.WithInput(nid, cons.NewInputGasInfo([]*coin.CoinWithRef{&gasCoin}, parameters.L1Default))
->>>>>>> 3dc40ada6 (refactor: Pass L1parameter to consensus)
 	}
 	tc.RunAll()
 	tc.PrintAllStatusStrings("After MP/SM proposals", t.Logf)

packages/chain/cons/input_gas_info.go

@@ -91,11 +91,7 @@ func (sync *syncNCImpl) tryCompleteInputs() gpa.OutMessages {
 	return cb(sync.haveInputAnchor)
 }
 
-<<<<<<< HEAD
 func (sync *syncNCImpl) HaveL1Info(gasCoins []*coin.CoinWithRef, l1params *parameters.L1Params) gpa.OutMessages {
-=======
-func (sync *syncNCImpl) HaveGasInfo(gasCoins []*coin.CoinWithRef, l1params *parameters.L1Params) gpa.OutMessages {
->>>>>>> 3dc40ada6 (refactor: Pass L1parameter to consensus)
 	if sync.gasCoins == nil && gasCoins != nil {
 		sync.gasCoins = gasCoins
 	}

packages/chain/cons/sync_nc.go

@@ -46,7 +46,6 @@ import (
 	"github.com/iotaledger/wasp/packages/isc"
 	"github.com/iotaledger/wasp/packages/metrics"
 	"github.com/iotaledger/wasp/packages/origin"
-	"github.com/iotaledger/wasp/packages/parameters"
 	"github.com/iotaledger/wasp/packages/peering"
 	"github.com/iotaledger/wasp/packages/registry"
 	"github.com/iotaledger/wasp/packages/shutdown"
@@ -1076,10 +1075,6 @@ func (cni *chainNodeImpl) LatestGasCoin(freshness StateFreshness) (*coin.CoinWit
 	return cni.nodeConn.GetGasCoinRef(context.Background(), cni.chainID)
 }
 
-func (cni *chainNodeImpl) LatestL1Parameters() *parameters.L1Params {
-	return parameters.L1()
-}
-
 func (cni *chainNodeImpl) LatestState(freshness StateFreshness) (state.State, error) {
 	cni.accessLock.RLock()
 	latestActiveState := cni.latestActiveState

packages/chain/node.go

@@ -1,12 +1,15 @@
 package vmimpl
 
 import (
+	"fmt"
 	"math"
 	"math/big"
 	"os"
 	"runtime/debug"
 	"time"
 
+	"github.com/iotaledger/wasp/clients/iota-go/iotago"
+	"github.com/iotaledger/wasp/clients/iota-go/iotago/iotatest"
 	"github.com/iotaledger/wasp/packages/coin"
 	"github.com/iotaledger/wasp/packages/hashing"
 	"github.com/iotaledger/wasp/packages/isc"
@@ -16,6 +19,7 @@ import (
 	"github.com/iotaledger/wasp/packages/kv/codec"
 	"github.com/iotaledger/wasp/packages/parameters"
 	"github.com/iotaledger/wasp/packages/util"
+	"github.com/iotaledger/wasp/packages/util/bcs"
 	"github.com/iotaledger/wasp/packages/util/panicutil"
 	"github.com/iotaledger/wasp/packages/vm"
 	"github.com/iotaledger/wasp/packages/vm/core/accounts"
@@ -57,7 +61,7 @@ func (vmctx *vmContext) runRequest(req isc.Request, requestIndex uint16, mainten
 
 	result, err := reqctx.callTheContract()
 	if err == nil {
-		err = vmctx.checkTransactionSize() // TODO is this a concern now?
+		err = vmctx.checkTransactionSize()
 	}
 	if err != nil {
 		// skip the request / rollback tx builder (no need to rollback the state, because the mutations will never be applied)
@@ -476,11 +480,23 @@ func (vmctx *vmContext) loadChainConfig() {
 
 // checkTransactionSize panics with ErrMaxTransactionSizeExceeded if the estimated transaction size exceeds the limit
 func (vmctx *vmContext) checkTransactionSize() error {
-	// TODO the following requirements we need to check
-	// * The encoded bytes of ptb should be smaller than `max_tx_size_bytes`
-	// * max_size_written_objects
-	// * max_serialized_tx_effects_size_bytes
-	// * max_pure_argument_size
-	vmctx.task.Log.Info("TODO: checkTransactionSize")
+	const maxTxSizeBytes = 128 * 1024
+	const maxInputObjects = 2048
+	const maxProgrammableTxCommands = 1024
+	ptb := vmctx.txbuilder.ViewPTB()
+	if ptb.Inputs.Len() > maxInputObjects {
+		return fmt.Errorf("ptb input len: %d, exceed max_input_objects", ptb.Inputs.Len())
+	}
+	if len(ptb.Commands) > maxProgrammableTxCommands {
+		return fmt.Errorf("ptb input len: %d, exceed max_programmable_tx_commands", len(ptb.Commands))
+	}
+	pt := ptb.Finish()
+	tx := iotago.NewProgrammable(
+		iotatest.RandomAddress(), pt, []*iotago.ObjectRef{iotatest.RandomObjectRef()}, 0, 0,
+	)
+	b, _ := bcs.Marshal(&tx)
+	if len(b) > maxTxSizeBytes {
+		return fmt.Errorf("ptb serialized size: %d, exceed max_tx_size_bytes", maxTxSizeBytes)
+	}
 	return nil
 }

packages/vm/vmimpl/runreq.go

@@ -20,4 +20,7 @@ type TransactionBuilder interface {
 
 	// this will reset txb into nil
 	BuildTransactionEssence(stateMetadata []byte, topUpAmount uint64) iotago.ProgrammableTransaction
+
+	// return a clone of PTB object for viewing
+	ViewPTB() *iotago.ProgrammableTransactionBuilder
 }

packages/vm/vmtxbuilder/interface.go

@@ -139,3 +139,7 @@ func (txb *AnchorTransactionBuilder) BuildTransactionEssence(stateMetadata []byt
 	}
 	return ptb.Finish()
 }
+
+func (txb *AnchorTransactionBuilder) ViewPTB() *iotago.ProgrammableTransactionBuilder {
+	return txb.ptb.Clone()
+}