Skip to content

Commit 228b124

Browse files
committed
To be useful, need to interpret this.webSocketHeaders on every reconnect
1 parent baa4542 commit 228b124

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/main/java/hudson/remoting/Engine.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ public void setWebSocket(boolean webSocket) {
415415
this.webSocket = webSocket;
416416
}
417417

418-
@CheckForNull
418+
@NonNull
419419
public Map<String, String> getWebSocketHeaders() {
420420
return webSocketHeaders != null ? Collections.unmodifiableMap(new LinkedHashMap<>(webSocketHeaders)) : Map.of();
421421
}
@@ -635,11 +635,6 @@ private void runWebSocket() {
635635
addedHeaders.put(JnlpConnectionState.CLIENT_NAME_KEY, List.of(agentName));
636636
addedHeaders.put(JnlpConnectionState.SECRET_KEY, List.of(secretKey));
637637
addedHeaders.put(Capability.KEY, List.of(localCap));
638-
if (webSocketHeaders != null) {
639-
for (Map.Entry<String, String> entry : webSocketHeaders.entrySet()) {
640-
addedHeaders.put(entry.getKey(), List.of(entry.getValue()));
641-
}
642-
}
643638
while (true) {
644639
AtomicReference<Channel> ch = new AtomicReference<>();
645640
class HeaderHandler extends ClientEndpointConfig.Configurator {
@@ -648,6 +643,11 @@ class HeaderHandler extends ClientEndpointConfig.Configurator {
648643
@Override
649644
public void beforeRequest(Map<String, List<String>> headers) {
650645
headers.putAll(addedHeaders);
646+
if (webSocketHeaders != null) {
647+
for (var entry : webSocketHeaders.entrySet()) {
648+
headers.put(entry.getKey(), List.of(entry.getValue()));
649+
}
650+
}
651651
LOGGER.fine(() -> "Sending: " + headers);
652652
}
653653

0 commit comments

Comments
 (0)