Avoid capturing Request in LogRecord parameters (#694)

jglick · web-flow · commit c3b7249b87eb · 2023-10-24T17:40:06.000-07:00
diff --git a/src/main/java/hudson/remoting/Request.java b/src/main/java/hudson/remoting/Request.java
@@ -393,7 +393,7 @@ public void run() {
                     // this means the caller will block forever
                     if (e instanceof ChannelClosedException && !logger.isLoggable(Level.FINE)) {
                         // TODO if this is from CloseCommand reduce level to FINE
-                        logger.log(Level.INFO, "Failed to send back a reply to the request {0}: {1}", new Object[] {Request.this, e});
+                        logger.info(() -> "Failed to send back a reply to the request " + Request.this + ": " + e);
                     } else {
                         logger.log(Level.WARNING, e, () -> "Failed to send back a reply to the request " + Request.this);
                     }

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ public void run() {`
`393`	`393`	`// this means the caller will block forever`
`394`	`394`	`if (e instanceof ChannelClosedException && !logger.isLoggable(Level.FINE)) {`
`395`	`395`	`// TODO if this is from CloseCommand reduce level to FINE`
`396`		`- logger.log(Level.INFO, "Failed to send back a reply to the request {0}: {1}", new Object[] {Request.this, e});`
	`396`	`+ logger.info(() -> "Failed to send back a reply to the request " + Request.this + ": " + e);`
`397`	`397`	`} else {`
`398`	`398`	`logger.log(Level.WARNING, e, () -> "Failed to send back a reply to the request " + Request.this);`
`399`	`399`	`}`