Bump org.jenkins-ci:jenkins from 1.129 to 1.130 (#785)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: dependabot[bot]

pom.xml

@@ -28,7 +28,7 @@ THE SOFTWARE.
   <parent>
     <groupId>org.jenkins-ci</groupId>
     <artifactId>jenkins</artifactId>
-    <version>1.129</version>
+    <version>1.130</version>
     <relativePath />
   </parent>
 

src/main/java/hudson/remoting/Channel.java

@@ -818,10 +818,6 @@ private ExecutorService createPipeWriterExecutor() {
      * This is the lowest layer of abstraction in {@link Channel}.
      * {@link Command}s are executed on a remote system in the order they are sent.
      */
-    @SuppressFBWarnings(
-            value = "VO_VOLATILE_INCREMENT",
-            justification =
-                    "The method is synchronized, no other usages. See https://sourceforge.net/p/findbugs/bugs/1032/")
     /*package*/ synchronized void send(Command cmd) throws IOException {
         if (outClosed != null) {
             throw new ChannelClosedException(this, outClosed);
@@ -1165,9 +1161,6 @@ protected V adapt(UserRequest.ResponseToUserRequest<V, T> r) throws ExecutionExc
      * @param e
      *      The error that caused the connection to be aborted. Never null.
      */
-    @SuppressFBWarnings(
-            value = "ITA_INEFFICIENT_TO_ARRAY",
-            justification = "intentionally; race condition on listeners otherwise")
     public void terminate(@NonNull IOException e) {
 
         if (e == null) {

src/main/java/hudson/remoting/ClassLoaderHolder.java

@@ -33,6 +33,7 @@ public void set(@CheckForNull ClassLoader classLoader) {
         this.classLoader = classLoader;
     }
 
+    @SuppressFBWarnings(value = "MC_OVERRIDABLE_METHOD_CALL_IN_READ_OBJECT", justification = "TODO needs triage")
     private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException {
         RemoteClassLoader.IClassLoader proxy = (RemoteClassLoader.IClassLoader) ois.readObject();
         classLoader = proxy == null

src/main/java/hudson/remoting/FileSystemJarCache.java

@@ -86,9 +86,6 @@ protected URL lookInCache(Channel channel, long sum1, long sum2) throws IOExcept
     }
 
     @Override
-    @SuppressFBWarnings(
-            value = "PATH_TRAVERSAL_IN",
-            justification = "The file path is a generated value based on server supplied data.")
     protected URL retrieve(Channel channel, long sum1, long sum2) throws IOException, InterruptedException {
         Checksum expected = new Checksum(sum1, sum2);
         File target = map(sum1, sum2);

src/main/java/hudson/remoting/Launcher.java

@@ -461,9 +461,6 @@ public static void main(String... args) throws IOException, InterruptedException
         }
     }
 
-    @SuppressFBWarnings(
-            value = "DM_DEFAULT_ENCODING",
-            justification = "log file, just like console output, should be in platform default encoding")
     public void run() throws CmdLineException, IOException, InterruptedException {
         if (showVersion) {
             String version = Util.getVersion();
@@ -1099,7 +1096,6 @@ private static void closeWithLogOnly(Closeable stream, String name) {
         }
     }
 
-    @SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "Parameter supplied by user / administrator.")
     private Engine createEngine() throws IOException {
         LOGGER.log(Level.INFO, "Setting up agent: {0}", name);
         Engine engine = new Engine(

src/main/java/hudson/remoting/RemoteInputStream.java

@@ -182,7 +182,7 @@ public void run() {
     }
 
     @SuppressFBWarnings(
-            value = "DESERIALIZATION_GADGET",
+            value = {"DESERIALIZATION_GADGET", "MC_OVERRIDABLE_METHOD_CALL_IN_READ_OBJECT"},
             justification = "Serializable only over remoting. Class filtering is done through JEP-200.")
     private void readObject(ObjectInputStream ois) throws IOException, ClassNotFoundException {
         final Channel channel = getChannelForSerialization();

src/main/java/hudson/remoting/URLDeserializationHelper.java

@@ -43,7 +43,6 @@
  */
 public class URLDeserializationHelper {
     // escape hatch for SECURITY-637 to keep legacy behavior
-    @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "Accessible via System Groovy Scripts")
     private static boolean AVOID_URL_WRAPPING =
             Boolean.getBoolean(URLDeserializationHelper.class + ".avoidUrlWrapping");