You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
docs(kep-5793): address review nits on admission control docs
- Link feature gate to specific #ManifestBasedAdmissionControlConfig
anchor in all four files
- Reword startup error to "fails to start, displaying a descriptive
error"
- Change "exist in an isolated universe" to "exist in isolation"
- Expand "config info" to "configuration information"
- Add HTML comment break between numbered list items for proper
rendering
- Reorder metrics table columns to Type, Description, Metric to
reduce side-scrolling
Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
file passed to the kube-apiserver via `--admission-control-config-file`.
@@ -129,12 +129,12 @@ When the feature gate is disabled, a warning is returned instead.
129
129
130
130
{{< note >}}
131
131
If two manifest files define objects of the same type with the same name, the
132
-
API server fails to start with a descriptive error.
132
+
API server fails to start, displaying a descriptive error.
133
133
{{< /note >}}
134
134
135
135
### Restrictions
136
136
137
-
Manifest-based admission configurations exist in an isolated universe and cannot
137
+
Manifest-based admission configurations exist in isolation and cannot
138
138
reference API resources. The following restrictions apply:
139
139
140
140
-**Webhooks**: Must use `clientConfig.url`. The `clientConfig.service` field is
@@ -229,6 +229,8 @@ The kube-apiserver watches the configured directories for changes:
229
229
previous valid configuration is retained.
230
230
- Successful reloads atomically replace the previous configuration.
231
231
232
+
<!---->
233
+
232
234
1.**Atomic file updates**: To avoid partial reads during file writes, make
233
235
changes atomically (for example, write to a temporary file and rename it).
234
236
This is especially important when updating mounted ConfigMaps or Secrets in
@@ -248,11 +250,11 @@ Manifest-based admission control provides the following metrics for monitoring
248
250
reload health:
249
251
250
252
{{< table caption="Metrics for manifest-based admission control" >}}
251
-
|Metric|Type|Description|
252
-
|:-------|:-----|:------------|
253
-
|`apiserver_manifest_admission_config_controller_automatic_reloads_total`|Counter | Total number of reload attempts, with `status` (`success` or `failure`), `plugin`, and `apiserver_id_hash` labels. |
254
-
|`apiserver_manifest_admission_config_controller_automatic_reload_last_timestamp_seconds`|Gauge | Timestamp of the last reload attempt, with `status`, `plugin`, and `apiserver_id_hash` labels. |
255
-
|`apiserver_manifest_admission_config_controller_last_config_info`|Gauge | Current configuration info (value is always 1), with `plugin`, `apiserver_id_hash`, and `hash` labels. Use the `hash` label to detect configuration drift across API servers. |
253
+
|Type|Description|Metric|
254
+
|:-----|:------------|:-------|
255
+
| Counter | Total number of reload attempts, with `status` (`success` or `failure`), `plugin`, and `apiserver_id_hash` labels.|`apiserver_manifest_admission_config_controller_automatic_reloads_total`|
256
+
| Gauge | Timestamp of the last reload attempt, with `status`, `plugin`, and `apiserver_id_hash` labels.|`apiserver_manifest_admission_config_controller_automatic_reload_last_timestamp_seconds`|
257
+
| Gauge | Current configuration information (value is always 1), with `plugin`, `apiserver_id_hash`, and `hash` labels. Use the `hash` label to detect configuration drift across API servers.|`apiserver_manifest_admission_config_controller_last_config_info`|
256
258
{{< /table >}}
257
259
258
260
The `plugin` label identifies which admission plugin the metric applies to:
0 commit comments