Add initial python bindings for c10 dispatcher internals. #55
Conversation
stellaraccident
commented
Sep 24, 2020
- Exposes the op registry via a get_registered_ops method.
- Moves the aten dialect generation scripts in prep for integrating them with this facility.
silvasean
left a comment
There was a problem hiding this comment.
Is there any meaningful test for this? Maybe it should wait for some later functionality to materialize. Feel free to skip.
| record["returns"] = std::move(returns); | ||
| results.append(std::move(record)); | ||
| }); | ||
| { dispatcher.addRegistrationListener(std::move(listener)); } |
There was a problem hiding this comment.
I find these braces hard to understand. Why are they needed?
There was a problem hiding this comment.
Ugh. Added this note:
// Note: addRegistrationListener reports all currently registered ops
// during the call and then incrementally reports newer ops until the RAII
// return value is destroyed. Since we only want the current, surround in
// a block so it immediately unregisters.
I didn't trace through any asynchronicity that may be involved and just wanted to ensure there was an unregistration prior to manipulating further.
I started adding a trivial FileCheck test, then realized that the test tree needs refactoring, and we should have a docker container anyway. Since this is the first meaningful functionality in the "new" way, let me check it in as-is and I'll untangle the test situation next. |
* Exposes the op registry via a get_registered_ops method. * Moves the aten dialect generation scripts in prep for integrating them with this facility.
ce824a7 to
5b0ac7e
Compare
|
FYI - added docker container and fixed the test tree in 0cb28f0 (and added a trivial test for this) |
Co-authored-by: Gheorghe-Teodor Bercea <[email protected]>