Skip to content

Commit ab0aef8

Browse files
committed
removed deprecated methods
1 parent 55699ea commit ab0aef8

File tree

2 files changed

+1
-18
lines changed

2 files changed

+1
-18
lines changed

lib/split/encapsulated_helper.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module EncapsulatedHelper
1515

1616
class ContextShim
1717
include Split::Helper
18-
public :ab_test, :finished, :ab_finished
18+
public :ab_test, :ab_finished
1919

2020
def initialize(context)
2121
@context = context
@@ -43,11 +43,6 @@ def ab_test(*arguments)
4343
end
4444
end
4545

46-
def ab_test_finished(*arguments)
47-
warn 'DEPRECATION WARNING: ab_test_finished is deprecated and will be removed from Split 2.0.0'
48-
split_context_shim.finished *arguments
49-
end
50-
5146
private
5247

5348
# instantiate and memoize a context shim in case of multiple ab_test* calls

lib/split/helper.rb

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -76,11 +76,6 @@ def ab_finished(metric_descriptor, options = {:reset => true})
7676
Split.configuration.db_failover_on_db_error.call(e)
7777
end
7878

79-
def finished(metric_descriptor, options = {:reset => true})
80-
warn 'DEPRECATION WARNING: finished method was renamed to ab_finished and will be removed in Split 2.0.0'
81-
ab_finished(metric_descriptor, options)
82-
end
83-
8479
def override_present?(experiment_name)
8580
override_alternative(experiment_name)
8681
end
@@ -93,13 +88,6 @@ def split_generically_disabled?
9388
defined?(params) && params['SPLIT_DISABLE']
9489
end
9590

96-
def begin_experiment(experiment, alternative_name = nil)
97-
warn 'DEPRECATION WARNING: begin_experiment is deprecated and will be removed from Split 2.0.0'
98-
alternative_name ||= experiment.control.name
99-
ab_user[experiment.key] = alternative_name
100-
alternative_name
101-
end
102-
10391
def ab_user
10492
@ab_user ||= User.new(self)
10593
end

0 commit comments

Comments
 (0)