clarify bitfield order, remove related TODOs, #2

Author: ThomasWaldmann

esp32_ulp/opcodes.py

@@ -47,7 +47,7 @@
 
 def make_ins_struct_def(layout):
     lines = layout.strip().splitlines()
-    pos = 0
+    pos = 0  # bitfield definitions start from lsb
     struct_def = {}
     for line in lines:
         bitfield = line.split('#', 1)[0]  # get rid of comment

tests/opcodes.py

@@ -3,16 +3,15 @@
 
 OPCODE_DELAY = 4
 LAYOUT_DELAY = """
-        cycles : 16     # Number of cycles to sleep
-        unused : 12     # Unused
-        opcode : 4      # Opcode (OPCODE_DELAY)
+    cycles : 16     # Number of cycles to sleep
+    unused : 12     # Unused
+    opcode : 4      # Opcode (OPCODE_DELAY)
 """
 
 
 def test_make_ins_struct_def():
     sd = make_ins_struct_def(LAYOUT_DELAY)
     assert set(sd) == {'cycles', 'unused', 'opcode', 'all'}
-    # TODO check if the expected values are correct (bitfield order)
     assert sd['cycles'] == BFUINT32 | 0 << BF_POS | 16 << BF_LEN
     assert sd['unused'] == BFUINT32 | 16 << BF_POS | 12 << BF_LEN
     assert sd['opcode'] == BFUINT32 | 28 << BF_POS | 4 << BF_LEN
@@ -27,9 +26,7 @@ def test_make_ins():
     assert _delay.cycles == 0x23
     assert _delay.unused == 0
     assert _delay.opcode == OPCODE_DELAY
-    # TODO: check if the expected value is correct (byte order, bitfield order)
-    expected = 0x40000023
-    assert _delay.all == expected, '%x != %x' % (_delay.all, expected)
+    assert _delay.all == 0x40000023
 
 
 test_make_ins_struct_def()