Integrated terminal mouse reporting not working

[probablykasper]

• VSCode 1.44.2
• macOS 10.14.6

Steps to Reproduce:

1. Open a file in vim by running vim <file> in the integrated terminal
2. Type :set mouse=a and press enter, to enable mouse reporting
3. Now, selecting text in the file you opened does not work

This apparently does not affect tmux.

Does this issue occur when all extensions are disabled?: Yes

[Tyriar]

tmux mouse events are working fine for me:

Version info:

Version: 1.45.0-insider
Commit: a250df7
Date: 2020-04-24T20:46:59.782Z
Electron: 7.2.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Darwin x64 19.0.0

[probablykasper]

@Tyriar My bad, I haven't tested this on tmux or emacs. I thought mouse reporting just wasn't supported at all, but that's clearly not the case. Updated the issue description.

Were you able to reproduce the issue in vim?

[Tyriar]

You're right it doesn't seem to be working for vim only. @jerch maybe a bug with the mouse protocol changes? 🤔

When entering vim:

xterm.js: Binding to mouse events: {down: true, up: true, drag: true, move: false, wheel: true}

Some clicks that don't seem to do anything:

xterm.js: sending binary "�[M #"" (6) [27, 91, 77, 32, 35, 34]
xterm.js: sending binary "�[M##"" (6) [27, 91, 77, 35, 35, 34]

xterm.js: sending binary "�[M */" (6) [27, 91, 77, 32, 42, 47]
xterm.js: sending binary "�[M#*/" (6) [27, 91, 77, 35, 42, 47]

tmux which works fine:

xterm.js: Binding to mouse events: {down: true, up: true, drag: true, move: false, wheel: true}

xterm.js: sending data "�[<0;31;8M" (10) [27, 91, 60, 48, 59, 51, 49, 59, 56, 77]
xterm.js: parsing data �[?25l�[32m�[1;45H│�[2;45H│�[3;45H│�[4;45H│�[5;45H│�[6;45H│�[7;45H│�[8;45H│�[9;45H│�[10;45H│�[11;45H│�[12;45H│�[13;45H│�[39m�[14;45H│�[15;45H│�[16;45H│�[17;45H│�[18;45H│�[19;45H│�[20;45H│�[21;45H│�[22;45H│�[23;45H│�[24;45H│�[25;45H│�(B�[m�[3;3H�[?12l�[?25h
xterm.js: sending data "�[<0;31;8m" (10) [27, 91, 60, 48, 59, 51, 49, 59, 56, 109]

[jerch]

@Tyriar vim works fine for me in xterm.js demo. Does vscode forward binary event data from onBinary?

[Tyriar]

@jerch that must be it, onBinary was never adopted.