Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mintoolkit/mint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mintoolkit/mint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix-exclude-pattern-9001659645140215213
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 9 files changed
  • 1 contributor

Commits on Dec 13, 2025

  1. fix: Handle /** in --exclude-pattern to prevent empty dirs 

    This commit fixes a regression in the `--exclude-pattern` flag where patterns ending in `/**` would not exclude the base directory, leading to empty directories in the final image.

The fix introduces an `addImplicitExcludes` function that augments the exclusion patterns to explicitly include the base directory when a pattern ends with `/**`. This function is now used in the `saveArtifacts` function in `pkg/app/sensor/artifact/artifact.go` to ensure that both the directory and its contents are excluded.

A new end-to-end test has been added to `pkg/app/sensor/exclude_test.go` to verify the fix.

Work in progress:
The new test case is currently failing due to issues with the test environment configuration. The test is unable to locate the `mint-sensor` executable and is encountering permission errors when trying to connect to the Docker daemon. Further work is needed to resolve these test environment issues.
    @google-labs-jules
    google-labs-jules[bot] committed Dec 13, 2025
    Configuration menu
    Copy the full SHA
    f8ceac6 View commit details
    Browse the repository at this point in the history
Loading