TCIContext(tree)$maximum overflow

[RussellGarwood]

Hi @ms609 - I'm implementing tci using TreeTools v1.11.1 as per this issue

palaeoware/trevosim#6

The file in the TREvoSim repository folder /comparison_to_empirical_data/Empirical_data/Echinoidea.tre (attached as a zip) throws an error when calculating TCIContext(tree)$maximum - it looks like an overflow:

Error in DoubleFactorial((x + x) - 2L) : 301!! is too large to represent. Use LnDoubleFactorial() instead.

This has 164 leaves, so it is not a massive tree, and I'm wondering if something other than size could be causing this issue.

Echinoidea.zip

[ms609]

Thanks for the report – this is fixed in #159, which I'll merge once tests are passed.

(I've a half-written reply to your question at palaeoware/trevosim#6 on my other computer, which I'll try to complete tonight!)

[ms609]

Should now be available via devtools::install_github("ms609/TreeTools")

[RussellGarwood]

Thanks for the rapid fix, @m609! And also for the answer to my question forthcoming - I've implemented this metric and the results are broadly the same, but am still interested in whether this is referable to Colless!