-
Notifications
You must be signed in to change notification settings - Fork 11
Description
Description
We would like to install the k8s metrics adapter via GitOps, where either ArgoCD or FluxCD is used to handle the installation. We cannot have an API key committed to git. Therefore, we need a method to install the helm chart without providing the secret in the values.yaml, and instead simply reference a secret by its name created via other means.
Acceptance Criteria
- Make a new key in values.yaml
personalAPIKeySecretNamewhere the value is the name of the secret created via external mechanism - Make the
secret.yamlcreation optional - Change line 65 of
deployment.yamlto accept the new value from values.yaml but fallback to the current value as a default ifpersonalAPIKeyis provided instead ofpersonalAPIKeySecretName
Describe Alternatives
There is no alternative method at this time. The chart requires the input of the personalAPIKey value on line 10 of secret.yaml
Dependencies
N/A
Additional context
Teams can either pre-create the secret manually or with other tools, such as External Secrets Operator. The goal is to keep secrets like this out of git commits.
Estimates
Please provide initial t-shirt size. S = 1-3 days, M = 3-5 days (1 week), L = 1-2 weeks (1 sprint)
S
For Maintainers Only or Hero Triaging this bug
Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):