chore: Added a new diagnostics base class and migrated undici to use new class (#3408)

Author: bizob2828

lib/config/build-instrumentation-config.js

@@ -12,8 +12,6 @@ const corePkgs = Object.keys(coreLibraries)
 const subscriptions = require('../subscriber-configs')
 const subscribers = Object.keys(subscriptions)
 pkgNames.push(...subscribers)
-// Manually adding undici as it is registered separately in shimmer
-corePkgs.push('undici')
 // Manually adding domain as it is registered separately in shimmer
 corePkgs.push('domain')
 pkgNames.push(...corePkgs)

lib/instrumentation-descriptor.js

@@ -86,14 +86,6 @@ class InstrumentationDescriptor {
    */
   static TYPE_WEB_FRAMEWORK = 'web-framework'
 
-  /**
-   * Used to load supportability metrics on installed versions of packages
-   * that the Node.js agent does not instrument (e.g. OTEL instrumentation or
-   * top logging libraries).
-   * @type {string}
-   */
-  static TYPE_TRACKING = 'tracking'
-
   /**
    * The type of the module being instrumented. See the static `TYPE_` fields.
    * @type {string|null}
@@ -207,7 +199,6 @@ module.exports.TYPES = {
   PROMISE: InstrumentationDescriptor.TYPE_PROMISE,
 
   WEB_FRAMEWORK: InstrumentationDescriptor.TYPE_WEB_FRAMEWORK,
-  TRACKING: InstrumentationDescriptor.TYPE_TRACKING,
   /** @private */
   CONGLOMERATE: InstrumentationDescriptor.TYPE_CONGLOMERATE,
   /** @private */

lib/instrumentation/undici.js

@@ -39,22 +39,6 @@ module.exports = function instrumentations() {
     restify: { type: InstrumentationDescriptor.TYPE_WEB_FRAMEWORK },
     superagent: { type: InstrumentationDescriptor.TYPE_GENERIC },
     when: { module: './instrumentation/when' },
-    winston: { type: InstrumentationDescriptor.TYPE_GENERIC },
-
-    /**
-     * The modules below are listed here purely to take
-     * advantage of the Supportability/Features/onRequire/<module>
-     * metrics for libraries we want to track for some reason or another.
-     * The big uses cases are:
-     *  Logging libraries we want to instrument in the future
-     *  Libraries that have OpenTelemetry instrumentation we want to register
-     *  or have already registered.
-     */
-    '@azure/openai': { type: InstrumentationDescriptor.TYPE_TRACKING },
-    '@langchain/community/llms/bedrock': { type: InstrumentationDescriptor.TYPE_TRACKING },
-    'fancy-log': { type: InstrumentationDescriptor.TYPE_TRACKING },
-    knex: { type: InstrumentationDescriptor.TYPE_TRACKING },
-    loglevel: { type: InstrumentationDescriptor.TYPE_TRACKING },
-    npmlog: { type: InstrumentationDescriptor.TYPE_TRACKING },
+    winston: { type: InstrumentationDescriptor.TYPE_GENERIC }
   }
 }