Complementary Linter / Static Analysis

[andychu]

This bug is for brainstorming.

• A script must pass bin/osh -O all:oil -n foo.sh first. That fixes some low hanging fruit.
• shopt -s all:oil allows BOTH styles of conditionals now: do done / then else fi, or { }.
  • The translation tool can normalize them all to { }
• pushd / popd -> cd with block
• set -> builtin set or maybe shopt
• warn about old-style assignments. Just assume no dynamic scope?
• translate short opts to long opts
  • for builtins: read -d -> read -delim Provide long options for all builtins #465
  • external tools? ln --verbose ? Would have to assume GNU or having wrappers Write wrappers for all POSIX utils that support GNU-style long options #464
• also see:
  • shopt -s no_old_builtins no_old_syntax. Some simple filters can be built into the interpreter?
  • it makes it more likely to stay clean over time ...

[andychu]

Some of this came up recently

• legacy syntax to disable with Oil #678 -- we're not going to have runtime options for everything. Instead we can punt this to a secondary tool.
• Allow defining subsets of OSH #468 -- for people who want to use pure Oil, pure POSIX, etc.

And again the autoformatter is very related

• Write an autoformatter for Oil #681
• Deallocate memory in C++ #785 -- new token representation format, which is also Use new Token representation for SimpleLexer to add location info #837

[bar-g]

(adding this according to #oil-help > test with invalid flags, and boolstatus:)

• provide a less performance needing "linting" solution for:
  'Error or False Pitfall' could be fixed with strictness 'Error or False Pitfall' could be fixed with strictness #2375 (only closed for reason not given)