Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openresty/lua-nginx-module
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openresty/lua-nginx-module
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: travis-1.27.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 10 files changed
  • 2 contributors

Commits on Aug 1, 2024

  1. bugfix: nginx crashed when binding local address failed from lua.

    0  0x00007f10b0b16c59 in __memcpy_ssse3_back () from /lib64/libc.so.6
    1  0x000000000042e2ba in ngx_sprintf_str (buf=<optimized out>, last=last@entry=0x7fff82779250 "P\251#\002", src=<optimized out>, len=192, hexadecimal=hexadecimal@entry=0) at src/core/ngx_string.c:586
    2  0x000000000042e824 in ngx_vslprintf (buf=<optimized out>, buf@entry=0x7fff82778279 "bind() failed (\347(G\300\a", last=last@entry=0x7fff82779250 "P\251#\002", fmt=0x59c7fc "V) failed",
       fmt@entry=0x59c7f6 "bind(%V) failed", args=args@entry=0x7fff82779258) at src/core/ngx_string.c:255
    3  0x000000000042a243 in ngx_log_error_core (level=level@entry=3, log=log@entry=0x2263360, err=98, fmt=fmt@entry=0x59c7f6 "bind(%V) failed") at src/core/ngx_log.c:137
    4  0x000000000044c4fc in ngx_event_connect_peer (pc=pc@entry=0x223a950) at src/event/ngx_event_connect.c:169
    5  0x000000000049af8c in ngx_http_upstream_connect (r=r@entry=0x22923b0, u=u@entry=0x223a940) at src/http/ngx_http_upstream.c:1562
    6  0x000000000049c410 in ngx_http_upstream_init_request (r=r@entry=0x22923b0) at src/http/ngx_http_upstream.c:826
    7  0x000000000049ee79 in ngx_http_upstream_init (r=0x22923b0) at src/http/ngx_http_upstream.c:554
    8  0x00000000004906ad in ngx_http_read_client_request_body (r=r@entry=0x22923b0, post_handler=0x49ed31 <ngx_http_upstream_init>) at src/http/ngx_http_request_body.c:47
    9  0x00000000004dba84 in ngx_http_proxy_handler (r=0x22923b0) at src/http/modules/ngx_http_proxy_module.c:1023
    10 0x00000000004822f4 in ngx_http_core_content_phase (r=0x22923b0, ph=<optimized out>) at src/http/ngx_http_core_module.c:1271
    11 0x000000000047cb13 in ngx_http_core_run_phases (r=0x22923b0) at src/http/ngx_http_core_module.c:885
    12 0x000000000047cc1e in ngx_http_handler (r=<optimized out>) at src/http/ngx_http_core_module.c:868
    13 0x0000000000485f0e in ngx_http_run_posted_requests (c=c@entry=0x227c8f0) at src/http/ngx_http_request.c:2470
    14 0x0000000000488b8b in ngx_http_process_request_headers (rev=rev@entry=0x22204f0) at src/http/ngx_http_request.c:1552
    15 0x0000000000488e83 in ngx_http_process_request_line (rev=rev@entry=0x22204f0) at src/http/ngx_http_request.c:1196
    16 0x0000000000489b82 in ngx_http_keepalive_handler (rev=0x22204f0) at src/http/ngx_http_request.c:3441
    17 0x00000000004556e1 in ngx_epoll_process_events (cycle=0x2213ce0, timer=<optimized out>, flags=<optimized out>) at src/event/modules/ngx_epoll_module.c:901
    18 0x000000000044a286 in ngx_process_events_and_timers (cycle=cycle@entry=0x2213ce0) at src/event/ngx_event.c:258
    19 0x00000000004546a1 in ngx_single_process_cycle (cycle=cycle@entry=0x2213ce0) at src/os/unix/ngx_process_cycle.c:323
    20 0x0000000000429793 in main (argc=<optimized out>, argv=<optimized out>) at src/core/nginx.c:384
    zhuizhuhaomeng committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    7d9d55a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e01ba2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6997e2 View commit details
    Browse the repository at this point in the history
  4. travis: bumped the NGINX core to 1.27.0.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1d9b13c View commit details
    Browse the repository at this point in the history
  5. updated branch for travis.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c93b900 View commit details
    Browse the repository at this point in the history
  6. minor tweaks.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    96bed14 View commit details
    Browse the repository at this point in the history
  7. updated travis.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    4caf972 View commit details
    Browse the repository at this point in the history
  8. minor tweaks.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    fcdcd7c View commit details
    Browse the repository at this point in the history
  9. added curl_error for http/3.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    268787c View commit details
    Browse the repository at this point in the history
  10. tests: t/020-subrequest.t: replace the random port with an unused fiv…

    …e-digit port.
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    55eb2d9 View commit details
    Browse the repository at this point in the history
  11. travis: updated branch in travis.yml.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    94b6934 View commit details
    Browse the repository at this point in the history
  12. bugfix: append new parameters to ngx_http_lua_ffi_balancer_set_curren…

    …t_peer at function end.
    
    Avoid inserting new parameters in the middle of the function to prevent core
    dumps when using old lua-resty-core with new lua-nginx-module.
    
    Example stack trace:
    
    ```
    Message: Process 1414245 (nginx) of user 1000 dumped core.
    
            Stack trace of thread 1414245:
            #0  0x00007ff596938285 __strlen_avx2 (libc.so.6 + 0x162285)
            #1  0x00007ff596f623d2 lj_cf_ffi_string (libluajit-5.1.so.2 + 0x523d2)
            #2  0x00007ff596f1bb4b lj_BC_FUNCC (libluajit-5.1.so.2 + 0xbb4b)
            #3  0x00007ff596f74223 lua_pcall (libluajit-5.1.so.2 + 0x64223)
            #4  0x00000000005044b7 n/a (/home/jiahao/work/org/lua-resty-core/work/nginx/sbin/nginx + 0x1044b7)
    ```
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c4257fe View commit details
    Browse the repository at this point in the history
  13. bugfix: append new parameters to ngx_http_lua_ffi_ssl_verify_client a…

    …t function end.
    
    Avoid inserting new parameters in the middle of the function to prevent core
    dumps when using old lua-resty-core with new lua-nginx-module.
    
    Example stack trace:
    
    ```
    Message: Process 2199905 (nginx) of user 1000 dumped core.
    
    Stack trace of thread 2199905:
        #0  0x00007ffaf1e4b385 in OPENSSL_sk_num (st=st@entry=0xffffffff) at crypto/stack/stack.c:382
        #1  0x0000000000510aba in sk_X509_num (sk=0xffffffff) at /opt/ssl/include/openssl/x509.h:99
        #2  ngx_http_lua_ffi_ssl_verify_client (r=<optimized out>, client_certs=<optimized out>, trusted_certs=0xffffffff, depth=<optimized out>, err=0x0)
            at /home/jiahao/work/org/lua-nginx-module/src/ngx_http_lua_ssl_certby.c:1588
    ```
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f7e8278 View commit details
    Browse the repository at this point in the history
  14. Revert "bugfix: append new parameters to ngx_http_lua_ffi_ssl_verify_…

    …client at function end."
    
    This reverts commit d7eadfb.
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    57ec47c View commit details
    Browse the repository at this point in the history
  15. Revert "bugfix: append new parameters to ngx_http_lua_ffi_balancer_se…

    …t_current_peer at function end."
    
    This reverts commit 1b27e3a.
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    cef5be8 View commit details
    Browse the repository at this point in the history
  16. dev: util/build.sh: fixed command line argument validation and enviro…

    …nment variable usage.
    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f671c6a View commit details
    Browse the repository at this point in the history
  17. tests: skip t/163-signal.t in check leak mode.

    jiahao committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    adb3f14 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    c05bde9 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. bugfix: fixed keepalive error in cosocket.

    This bug was found in t/129-ssl-socket.t Test 18 when TEST_NGINX_EVENT_TYPE=poll enabled.
    zhuizhuhaomeng authored and jiahao committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    b38f467 View commit details
    Browse the repository at this point in the history
Loading