ext/intl: dateformatter settimezone changes on success, returning true

devnexen · devnexen · commit 356541102103 · 2023-03-05T20:57:51.000Z
like setcalendar.
diff --git a/UPGRADING b/UPGRADING
@@ -76,6 +76,9 @@ PHP 8.3 UPGRADE NOTES
 - Dom:
   . Changed DOMCharacterData::appendData() tentative return type to true.
 
+- Intl:
+  . IntlDateformatter::setTimeZone returns true on sucess.
+
 - MBString:
   . mb_strtolower, mb_strtotitle, and mb_convert_case implement conditional
     casing rules for the Greek letter sigma. For mb_convert_case, conditional
diff --git a/ext/intl/dateformat/dateformat.stub.php b/ext/intl/dateformat/dateformat.stub.php
@@ -136,7 +136,7 @@ public function getTimeZone(): IntlTimeZone|false {}
      * @tentative-return-type
      * @alias datefmt_set_timezone
      */
-    public function setTimeZone($timezone): ?bool {} // TODO return true on success
+    public function setTimeZone($timezone): bool {}
 
     /**
      * @tentative-return-type
diff --git a/ext/intl/dateformat/dateformat_arginfo.h b/ext/intl/dateformat/dateformat_arginfo.h
diff --git a/ext/intl/dateformat/dateformat_attrcpp.cpp b/ext/intl/dateformat/dateformat_attrcpp.cpp
@@ -101,6 +101,8 @@ U_CFUNC PHP_FUNCTION(datefmt_set_timezone)
 	}
 
 	fetch_datefmt(dfo)->adoptTimeZone(timezone);
+
+	RETURN_TRUE;
 }
 
 /* {{{ Get formatter calendar type. */

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,8 @@ U_CFUNC PHP_FUNCTION(datefmt_set_timezone)`
`101`	`101`	`}`
`102`	`102`
`103`	`103`	`fetch_datefmt(dfo)->adoptTimeZone(timezone);`
	`104`	`+`
	`105`	`+ RETURN_TRUE;`
`104`	`106`	`}`
`105`	`107`
`106`	`108`	`/* {{{ Get formatter calendar type. */`