Skip to content

Commit a2fde39

Browse files
committed
Remove always-true condition from php_dom_iterator_move_forward()
basenode is already checked above
1 parent b355315 commit a2fde39

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

ext/dom/dom_iterators.c

+1-2
Original file line numberDiff line numberDiff line change
@@ -219,8 +219,7 @@ static void php_dom_iterator_move_forward(zend_object_iterator *iter) /* {{{ */
219219
if (php_dom_is_cache_tag_stale_from_node(&iterator->cache_tag, basenode)) {
220220
php_dom_mark_cache_tag_up_to_date_from_node(&iterator->cache_tag, basenode);
221221
previndex = 0;
222-
if (basenode && (basenode->type == XML_DOCUMENT_NODE ||
223-
basenode->type == XML_HTML_DOCUMENT_NODE)) {
222+
if (basenode->type == XML_DOCUMENT_NODE || basenode->type == XML_HTML_DOCUMENT_NODE) {
224223
curnode = xmlDocGetRootElement((xmlDoc *) basenode);
225224
} else {
226225
curnode = basenode->children;

0 commit comments

Comments
 (0)