ext/intl: dateformatter settimezone changes on success, returning true

like setcalendar.

Author: devnexen

UPGRADING

@@ -76,6 +76,10 @@ PHP 8.3 UPGRADE NOTES
 - Dom:
   . Changed DOMCharacterData::appendData() tentative return type to true.
 
+- Intl:
+  . IntlDateformatter::setTimeZone now returns true on sucess, previously null
+    was returned.
+
 - MBString:
   . mb_strtolower, mb_strtotitle, and mb_convert_case implement conditional
     casing rules for the Greek letter sigma. For mb_convert_case, conditional

ext/intl/dateformat/dateformat.stub.php

@@ -136,7 +136,7 @@ public function getTimeZone(): IntlTimeZone|false {}
      * @tentative-return-type
      * @alias datefmt_set_timezone
      */
-    public function setTimeZone($timezone): ?bool {} // TODO return true on success
+    public function setTimeZone($timezone): bool {}
 
     /**
      * @tentative-return-type

ext/intl/dateformat/dateformat_arginfo.h

@@ -101,6 +101,8 @@ U_CFUNC PHP_FUNCTION(datefmt_set_timezone)
 	}
 
 	fetch_datefmt(dfo)->adoptTimeZone(timezone);
+
+	RETURN_TRUE;
 }
 
 /* {{{ Get formatter calendar type. */

ext/intl/dateformat/dateformat_attrcpp.cpp

@@ -37,7 +37,7 @@ function ut_main()
 
         $res_str .= "-----------";
         $res_str .= "\nTrying to set timezone_id= $timezone_id_entry";
-        ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry );
+        if (ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry ) !== true) die("ut_datefmt_set_timezone_id failed");
         $timezone_id = ut_datefmt_get_timezone_id( $fmt );
         $res_str .= "\nAfter call to set_timezone_id :  timezone_id= $timezone_id";
         $formatted = ut_datefmt_format( $fmt, 0);

ext/intl/tests/dateformat_set_timezone_id2.phpt

@@ -20,10 +20,10 @@ ini_set("intl.error_level", E_WARNING);
 function ut_main()
 {
     $timezone_id_arr = array (
-        'America/New_York',
-        'America/Los_Angeles',
-        'America/Chicago',
-        'CN'
+        'America/New_York' => true,
+        'America/Los_Angeles' => true,
+        'America/Chicago' => true,
+        'CN' => false
     );
     $timestamp_entry = 0;
 
@@ -33,12 +33,12 @@ function ut_main()
     $timezone_id = ut_datefmt_get_timezone_id( $fmt );
     $res_str .= "\nAfter creation of the dateformatter :  timezone_id= $timezone_id\n";
 
-    foreach( $timezone_id_arr as $timezone_id_entry )
+    foreach( $timezone_id_arr as $timezone_id_entry => $result )
     {
 
         $res_str .= "-----------";
         $res_str .= "\nTrying to set timezone_id= $timezone_id_entry";
-        ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry );
+        if (ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry ) !== $result) die("ut_datefmt_set_timezone_id failed");
         $timezone_id = ut_datefmt_get_timezone_id( $fmt );
         $res_str .= "\nAfter call to set_timezone_id :  timezone_id= $timezone_id";
         $formatted = ut_datefmt_format( $fmt, 0);

ext/intl/tests/dateformat_set_timezone_id3.phpt

@@ -19,10 +19,10 @@ ini_set("intl.error_level", E_WARNING);
 function ut_main()
 {
     $timezone_id_arr = array (
-        'America/New_York',
-        'America/Los_Angeles',
-        'America/Chicago',
-        'CN'
+        'America/New_York' => true,
+        'America/Los_Angeles' => true,
+        'America/Chicago' => true,
+        'CN' => false
     );
     $timestamp_entry = 0;
 
@@ -32,12 +32,12 @@ function ut_main()
     $timezone_id = ut_datefmt_get_timezone_id( $fmt );
     $res_str .= "\nAfter creation of the dateformatter :  timezone_id= $timezone_id\n";
 
-    foreach( $timezone_id_arr as $timezone_id_entry )
+    foreach( $timezone_id_arr as $timezone_id_entry => $result )
     {
 
         $res_str .= "-----------";
         $res_str .= "\nTrying to set timezone_id= $timezone_id_entry";
-        ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry );
+        if (ut_datefmt_set_timezone_id( $fmt , $timezone_id_entry ) !== $result) die("ut_datefmt_set_timezone_id failed");
         $timezone_id = ut_datefmt_get_timezone_id( $fmt );
         $res_str .= "\nAfter call to set_timezone_id :  timezone_id= $timezone_id";
         $formatted = ut_datefmt_format( $fmt, 0);