Skip to content

ext/json: Remove zend_never_inline qualifier for php_json_is_valid_double() #18420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Girgias opened this issue Apr 24, 2025 · 1 comment
Open

Comments

@Girgias
Copy link
Member

Girgias commented Apr 24, 2025

Description

It seems the MSVC bug has been resolved:

@cmb69 you know more about Windows than I do, so is this proposal reasonable?

@cmb69
Copy link
Member

cmb69 commented Apr 24, 2025

Hmm, unsure. The first bug report was about ARM64 (and the preprocessor conditional is too), but that ticket has been closed as duplicate of the second report which is not particularly about ARM64. Now that second ticket claims the issue had been fixed in VS 17.3, which is available for more than 2 years. Assuming that the issue had been fixed for ARM64 back then as well, removing the conditinal makes sense to me. Unfortunately, there are still no public GH runners for ARM64 on Windows available, so I wouldn't be able to double-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants