Skip to content

Tests improvement for round() modes #11996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Tests improvement for round() modes #11996

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9a4f32
Improved the tests for round() function
jorgsowa Aug 18, 2023
0b62ca4
Add EOL on the file ending
jorgsowa Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
313 changes: 281 additions & 32 deletions ext/standard/tests/math/round_modes.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,286 @@
round() with different rounding modes
--FILE--
<?php
var_dump (round (2.5, 0, PHP_ROUND_HALF_UP));
var_dump (round (2.5, 0, PHP_ROUND_HALF_DOWN));
var_dump (round (2.5, 0, PHP_ROUND_HALF_EVEN));
var_dump (round (2.5, 0, PHP_ROUND_HALF_ODD));
var_dump (round (-2.5, 0, PHP_ROUND_HALF_UP));
var_dump (round (-2.5, 0, PHP_ROUND_HALF_DOWN));
var_dump (round (-2.5, 0, PHP_ROUND_HALF_EVEN));
var_dump (round (-2.5, 0, PHP_ROUND_HALF_ODD));
var_dump (round (3.5, 0, PHP_ROUND_HALF_UP));
var_dump (round (3.5, 0, PHP_ROUND_HALF_DOWN));
var_dump (round (3.5, 0, PHP_ROUND_HALF_EVEN));
var_dump (round (3.5, 0, PHP_ROUND_HALF_ODD));
var_dump (round (-3.5, 0, PHP_ROUND_HALF_UP));
var_dump (round (-3.5, 0, PHP_ROUND_HALF_DOWN));
var_dump (round (-3.5, 0, PHP_ROUND_HALF_EVEN));
var_dump (round (-3.5, 0, PHP_ROUND_HALF_ODD));
$modes = [
"PHP_ROUND_HALF_UP" => PHP_ROUND_HALF_UP,
"PHP_ROUND_HALF_DOWN" => PHP_ROUND_HALF_DOWN,
"PHP_ROUND_HALF_EVEN" => PHP_ROUND_HALF_EVEN,
"PHP_ROUND_HALF_ODD" => PHP_ROUND_HALF_ODD,
];

$numbers = [
2.5,
-2.5,
3.5,
-3.5,
7,
-7,
0.61,
0.69,
0,
1.9999,
-1.9999,
0.0001,
-0.0001,
];
$precisions = [0, 1, 2, 10];

foreach ($modes as $modeKey => $mode) {
echo "mode: $modeKey\n";
foreach ($precisions as $precision) {
echo "\tprecision: $precision\n";
foreach ($numbers as $number) {
$result = round($number, $precision);
echo "\t\t" .
str_pad($number, 7, " ", STR_PAD_LEFT) .
" => $result\n";
}
echo "\n";
}
}

?>
--EXPECT--
float(3)
float(2)
float(2)
float(3)
float(-3)
float(-2)
float(-2)
float(-3)
float(4)
float(3)
float(4)
float(3)
float(-4)
float(-3)
float(-4)
float(-3)
mode: PHP_ROUND_HALF_UP
precision: 0
2.5 => 3
-2.5 => -3
3.5 => 4
-3.5 => -4
7 => 7
-7 => -7
0.61 => 1
0.69 => 1
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 1
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.6
0.69 => 0.7
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 2
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 10
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 1.9999
-1.9999 => -1.9999
0.0001 => 0.0001
-0.0001 => -0.0001

mode: PHP_ROUND_HALF_DOWN
precision: 0
2.5 => 3
-2.5 => -3
3.5 => 4
-3.5 => -4
7 => 7
-7 => -7
0.61 => 1
0.69 => 1
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 1
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.6
0.69 => 0.7
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 2
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 10
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 1.9999
-1.9999 => -1.9999
0.0001 => 0.0001
-0.0001 => -0.0001

mode: PHP_ROUND_HALF_EVEN
precision: 0
2.5 => 3
-2.5 => -3
3.5 => 4
-3.5 => -4
7 => 7
-7 => -7
0.61 => 1
0.69 => 1
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 1
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.6
0.69 => 0.7
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 2
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 10
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 1.9999
-1.9999 => -1.9999
0.0001 => 0.0001
-0.0001 => -0.0001

mode: PHP_ROUND_HALF_ODD
precision: 0
2.5 => 3
-2.5 => -3
3.5 => 4
-3.5 => -4
7 => 7
-7 => -7
0.61 => 1
0.69 => 1
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 1
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.6
0.69 => 0.7
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 2
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 2
-1.9999 => -2
0.0001 => 0
-0.0001 => -0

precision: 10
2.5 => 2.5
-2.5 => -2.5
3.5 => 3.5
-3.5 => -3.5
7 => 7
-7 => -7
0.61 => 0.61
0.69 => 0.69
0 => 0
1.9999 => 1.9999
-1.9999 => -1.9999
0.0001 => 0.0001
-0.0001 => -0.0001