ddl: add more corner tests for active-active (#66252)

xhebox · web-flow · commit c7e7cb71593c · 2026-02-14T06:42:56.000Z
ref #64281
diff --git a/br/cmd/br/BUILD.bazel b/br/cmd/br/BUILD.bazel
@@ -34,6 +34,7 @@ go_library(
         "//br/pkg/version/build",
         "//pkg/config",
         "//pkg/meta/model",
+        "//pkg/parser/mysql",
         "//pkg/session",
         "//pkg/util",
         "//pkg/util/gctuner",
diff --git a/br/cmd/br/cmd.go b/br/cmd/br/cmd.go
@@ -21,6 +21,7 @@ import (
 	"github.com/pingcap/tidb/br/pkg/utils"
 	"github.com/pingcap/tidb/br/pkg/version/build"
 	"github.com/pingcap/tidb/pkg/config"
+	"github.com/pingcap/tidb/pkg/parser/mysql"
 	tidbutils "github.com/pingcap/tidb/pkg/util"
 	"github.com/pingcap/tidb/pkg/util/logutil"
 	"github.com/pingcap/tidb/pkg/util/memory"
@@ -51,6 +52,7 @@ var (
 		"mysql.default_roles",
 		"mysql.role_edges",
 		"!sys.*",
+		fmt.Sprintf("!%s.*", mysql.TiCDCSystemDB),
 		"!INFORMATION_SCHEMA.*",
 		"!PERFORMANCE_SCHEMA.*",
 		"!METRICS_SCHEMA.*",
diff --git a/br/pkg/task/stream.go b/br/pkg/task/stream.go
@@ -1396,7 +1396,8 @@ func RunStreamRestore(
 	}
 	// TODO: pitr filtered restore doesn't support restore system table yet
 	if cfg.ExplicitFilter {
-		if cfg.TableFilter.MatchSchema(mysql.SystemDB) || cfg.TableFilter.MatchSchema(mysql.SysDB) {
+		if cfg.TableFilter.MatchSchema(mysql.SystemDB) ||
+			cfg.TableFilter.MatchSchema(mysql.SysDB) {
 			return errors.Annotatef(berrors.ErrInvalidArgument,
 				"PiTR doesn't support custom filter to include system db, consider to exclude system db")
 		}
diff --git a/br/pkg/utils/schema_test.go b/br/pkg/utils/schema_test.go
@@ -2,6 +2,8 @@ package utils
 
 import (
 	"testing"
+
+	"github.com/pingcap/tidb/pkg/parser/mysql"
 )
 
 func TestIsSysOrTempSysDB(t *testing.T) {
@@ -25,6 +27,11 @@ func TestIsSysOrTempSysDB(t *testing.T) {
 			db:       "workload_schema",
 			expected: false,
 		},
+		{
+			name:     "tidb_cdc non-system db",
+			db:       mysql.TiCDCSystemDB,
+			expected: false,
+		},
 		{
 			name:     "temporary mysql db",
 			db:       "__TiDB_BR_Temporary_mysql",
@@ -40,6 +47,11 @@ func TestIsSysOrTempSysDB(t *testing.T) {
 			db:       "__TiDB_BR_Temporary_workload_schema",
 			expected: false,
 		},
+		{
+			name:     "temporary tidb_cdc db",
+			db:       "__TiDB_BR_Temporary_" + mysql.TiCDCSystemDB,
+			expected: false,
+		},
 		{
 			name:     "normal db",
 			db:       "test",
diff --git a/pkg/ddl/create_table.go b/pkg/ddl/create_table.go
@@ -822,7 +822,7 @@ func BuildTableInfoWithStmt(ctx *metabuild.Context, s *ast.CreateTableStmt, dbIn
 	}
 
 	var tbInfo *model.TableInfo
-	tbInfo, err = BuildTableInfo(ctx, s.Table.Name, cols, newConstraints, tableCharset, tableCollate)
+	tbInfo, err = BuildTableInfo(ctx, s.Table.Name, cols, newConstraints, tableCharset, tableCollate, optInfo)
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
@@ -1416,13 +1416,18 @@ func BuildTableInfo(
 	constraints []*ast.Constraint,
 	charset string,
 	collate string,
+	optInfo *model.TableInfo,
 ) (tbInfo *model.TableInfo, err error) {
 	tbInfo = &model.TableInfo{
 		Name:    tableName,
 		Version: model.CurrLatestTableInfoVersion,
 		Charset: charset,
 		Collate: collate,
 	}
+	if optInfo != nil {
+		tbInfo.SoftdeleteInfo = optInfo.SoftdeleteInfo
+		tbInfo.IsActiveActive = optInfo.IsActiveActive
+	}
 	tblColumns := make([]*table.Column, 0, len(cols))
 	existedColsMap := make(map[string]struct{}, len(cols))
 	for _, v := range cols {
diff --git a/pkg/ddl/executor.go b/pkg/ddl/executor.go
@@ -1575,7 +1575,7 @@ func (e *executor) CreateView(ctx sessionctx.Context, s *ast.CreateViewStmt) (er
 		tblCollate = v
 	}
 
-	tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, tblCharset, tblCollate)
+	tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, tblCharset, tblCollate, nil)
 	if err != nil {
 		return err
 	}
@@ -6104,7 +6104,7 @@ func (e *executor) CreateSequence(ctx sessionctx.Context, stmt *ast.CreateSequen
 		return err
 	}
 	// TiDB describe the sequence within a tableInfo, as a same-level object of a table and view.
-	tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), ident.Name, nil, nil, "", "")
+	tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), ident.Name, nil, nil, "", "", nil)
 	if err != nil {
 		return err
 	}
diff --git a/pkg/ddl/index.go b/pkg/ddl/index.go
@@ -356,6 +356,10 @@ func BuildIndexInfo(
 		return nil, errors.Trace(err)
 	}
 
+	if !isPrimary && isUnique && (tblInfo.IsActiveActive || tblInfo.SoftdeleteInfo != nil) {
+		return nil, errors.Trace(dbterror.ErrAlterOperationNotSupported.GenWithStackByArgs("UNIQUE", "Cannot create unique index on ACTIVE_ACTIVE or softdelete table", "removing UNIQUE"))
+	}
+
 	// Create index info.
 	idxInfo := &model.IndexInfo{
 		Name:    indexName,
diff --git a/pkg/ddl/mock.go b/pkg/ddl/mock.go
@@ -61,7 +61,7 @@ func MockTableInfo(sctx sessionctx.Context, stmt *ast.CreateTableStmt, tableID i
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
-	tbl, err := BuildTableInfo(ctx, stmt.Table.Name, cols, newConstraints, "", "")
+	tbl, err := BuildTableInfo(ctx, stmt.Table.Name, cols, newConstraints, "", "", nil)
 	if err != nil {
 		return nil, errors.Trace(err)
 	}
diff --git a/pkg/ddl/schematracker/dm_tracker.go b/pkg/ddl/schematracker/dm_tracker.go
@@ -276,7 +276,7 @@ func (d *SchemaTracker) CreateView(ctx sessionctx.Context, s *ast.CreateViewStmt
 		})
 	}
 
-	tbInfo, err := ddl.BuildTableInfo(ddl.NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, "", "")
+	tbInfo, err := ddl.BuildTableInfo(ddl.NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, "", "", nil)
 	if err != nil {
 		return err
 	}
diff --git a/pkg/executor/show.go b/pkg/executor/show.go
@@ -730,6 +730,9 @@ func (e *ShowExec) fetchShowColumns(ctx context.Context) error {
 		} else if fieldPatternsLike != nil && !fieldPatternsLike.DoMatch(col.Name.L) {
 			continue
 		}
+		if skipColumnInShowCreateTable(tb.Meta(), col.ColumnInfo, false) {
+			continue
+		}
 		desc := table.NewColDesc(col)
 		var columnDefault any
 		if desc.DefaultValue != nil {
@@ -1080,13 +1083,7 @@ func constructResultOfShowCreateTable(ctx sessionctx.Context, dbName *pmodel.CIS
 	var hasAutoIncID bool
 	needAddComma := false
 	for i, col := range tableInfo.Cols() {
-		if col == nil || col.Hidden || col.Name == model.ExtraHandleName || col.Name == model.ExtraOriginTSName {
-			continue
-		}
-		if tableInfo.SoftdeleteInfo != nil && model.IsSoftDeleteColumn(col.Name) {
-			continue
-		}
-		if tableInfo.IsActiveActive && model.IsActiveActiveColumn(col.Name) {
+		if skipColumnInShowCreateTable(tableInfo, col, true) {
 			continue
 		}
 		if needAddComma {
@@ -1680,6 +1677,27 @@ func fetchShowCreateTable4View(ctx sessionctx.Context, tb *model.TableInfo, buf
 	fmt.Fprintf(buf, ") AS %s", tb.View.SelectStmt)
 }
 
+func skipColumnInShowCreateTable(tableInfo *model.TableInfo, col *model.ColumnInfo, hidden bool) bool {
+	if col == nil || col.Name == model.ExtraHandleName || col.Name == model.ExtraOriginTSName {
+		return true
+	}
+	if hidden && col.Hidden {
+		return true
+	}
+	// Keep the existing show-create-table behavior for base tables.
+	if tableInfo.SoftdeleteInfo != nil && model.IsSoftDeleteColumn(col.Name) {
+		return true
+	}
+	if tableInfo.IsActiveActive && model.IsActiveActiveColumn(col.Name) {
+		return true
+	}
+	// Views do not carry softdelete/active-active flags, but should still hide these internal columns.
+	if tableInfo.IsView() && (model.IsSoftDeleteColumn(col.Name) || model.IsActiveActiveColumn(col.Name)) {
+		return true
+	}
+	return false
+}
+
 // ConstructResultOfShowCreateDatabase constructs the result for show create database.
 func ConstructResultOfShowCreateDatabase(ctx sessionctx.Context, dbInfo *model.DBInfo, ifNotExists bool, buf *bytes.Buffer) (err error) {
 	sqlMode := ctx.GetSessionVars().SQLMode
diff --git a/pkg/meta/model/table.go b/pkg/meta/model/table.go
@@ -288,6 +288,9 @@ func (t *TableInfo) Clone() *TableInfo {
 	if t.TTLInfo != nil {
 		nt.TTLInfo = t.TTLInfo.Clone()
 	}
+	if t.SoftdeleteInfo != nil {
+		nt.SoftdeleteInfo = t.SoftdeleteInfo.Clone()
+	}
 
 	if t.Affinity != nil {
 		nt.Affinity = t.Affinity.Clone()
diff --git a/pkg/parser/mysql/const.go b/pkg/parser/mysql/const.go
@@ -203,6 +203,10 @@ const (
 	// SysDB is the name of `sys` schema, which is a set of objects to help users to interpret data collected
 	// in `information_schema`.
 	SysDB = "sys"
+	// TiCDCSystemDB is the name of TiCDC's system database.
+	TiCDCSystemDB = "tidb_cdc"
+	// TiCDCProgressTable is the table storing TiCDC progress checkpoints.
+	TiCDCProgressTable = "ticdc_progress_table"
 	// GlobalPrivTable is the table in system db contains global scope privilege info.
 	GlobalPrivTable = "global_priv"
 	// UserTable is the table in system db contains user info.
diff --git a/pkg/ttl/session/BUILD.bazel b/pkg/ttl/session/BUILD.bazel
@@ -8,6 +8,7 @@ go_library(
     deps = [
         "//pkg/infoschema",
         "//pkg/kv",
+        "//pkg/parser/mysql",
         "//pkg/parser/terror",
         "//pkg/sessionctx",
         "//pkg/sessionctx/variable",
diff --git a/pkg/ttl/session/session.go b/pkg/ttl/session/session.go
@@ -22,6 +22,7 @@ import (
 	"github.com/pingcap/errors"
 	"github.com/pingcap/tidb/pkg/infoschema"
 	"github.com/pingcap/tidb/pkg/kv"
+	"github.com/pingcap/tidb/pkg/parser/mysql"
 	"github.com/pingcap/tidb/pkg/parser/terror"
 	"github.com/pingcap/tidb/pkg/sessionctx"
 	"github.com/pingcap/tidb/pkg/sessionctx/variable"
@@ -36,9 +37,6 @@ import (
 
 const minActiveActiveCheckpointTSRefreshInterval = time.Minute
 
-const tiCDCProgressDB = "tidb_cdc"
-const tiCDCProgressTable = "ticdc_progress_table"
-
 // TTLJobType represents the type of TTL job
 type TTLJobType = string
 
@@ -244,8 +242,8 @@ func (s *session) GetMinActiveActiveCheckpointTS(ctx context.Context, dbName, ta
 
 	sql := fmt.Sprintf(
 		"SELECT IFNULL(MIN(checkpoint_ts), 0) FROM %s.%s WHERE database_name=%%? AND table_name=%%?",
-		tiCDCProgressDB,
-		tiCDCProgressTable,
+		mysql.TiCDCSystemDB,
+		mysql.TiCDCProgressTable,
 	)
 
 	rows, err := s.ExecuteSQL(ctx,
diff --git a/pkg/ttl/sqlbuilder/sql.go b/pkg/ttl/sqlbuilder/sql.go
@@ -33,12 +33,6 @@ import (
 	"github.com/pingcap/tidb/pkg/util/sqlescape"
 )
 
-// TiCDCProgressDB is the database storing TiCDC progress table.
-const TiCDCProgressDB = "tidb_cdc"
-
-// TiCDCProgressTable is the table storing TiCDC progress checkpoints for hard-delete safety.
-const TiCDCProgressTable = "ticdc_progress_table"
-
 // SQLGenerator is the interface for SQL generators.
 type SQLGenerator interface {
 	NextSQL(continueFromResult [][]types.Datum, nextLimit int) (string, error)
diff --git a/pkg/ttl/sqlbuilder/sql_test.go b/pkg/ttl/sqlbuilder/sql_test.go
@@ -501,9 +501,9 @@ func TestSoftDeleteSQLActiveActiveSafety(t *testing.T) {
 func TestActiveActiveSafetySQLExecutable(t *testing.T) {
 	store, _ := testkit.CreateMockStoreAndDomain(t)
 	tk := testkit.NewTestKit(t, store)
-	tk.MustExec(fmt.Sprintf("create database if not exists %s", sqlbuilder.TiCDCProgressDB))
+	tk.MustExec(fmt.Sprintf("create database if not exists %s", mysql.TiCDCSystemDB))
 	// Use smaller column sizes to avoid key length limitations in tests.
-	tk.MustExec(fmt.Sprintf("create table if not exists %s.%s (changefeed_id varchar(64), upstreamID varchar(64), database_name varchar(64), table_name varchar(64), checkpoint_ts bigint unsigned, primary key(changefeed_id, upstreamID, database_name, table_name))", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
+	tk.MustExec(fmt.Sprintf("create table if not exists %s.%s (changefeed_id varchar(64), upstreamID varchar(64), database_name varchar(64), table_name varchar(64), checkpoint_ts bigint unsigned, primary key(changefeed_id, upstreamID, database_name, table_name))", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
 
 	preparePhysicalTable := func(t *testing.T) *cache.PhysicalTable {
 		is := domain.GetDomain(tk.Session()).InfoSchema()
@@ -540,7 +540,7 @@ func TestActiveActiveSafetySQLExecutable(t *testing.T) {
 	}
 
 	t.Run("LocalTombstone", func(t *testing.T) {
-		tk.MustExec(fmt.Sprintf("delete from %s.%s", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
+		tk.MustExec(fmt.Sprintf("delete from %s.%s", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
 		tk.MustExec("use test")
 		tk.MustExec("drop table if exists t")
 		tk.MustExec("create table t(id int primary key, v int) active_active='on' softdelete retention 1 day softdelete_job_enable='ON'")
@@ -558,16 +558,16 @@ func TestActiveActiveSafetySQLExecutable(t *testing.T) {
 		// No progress
 		run(t, pt, expire, 0, false, false)
 		// Deleted
-		tk.MustExec(fmt.Sprintf("insert into %s.%s select 'cf','1','test','t', cast(IFNULL(_tidb_origin_ts, _tidb_commit_ts) as unsigned)+1 from test.t where id=1", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
+		tk.MustExec(fmt.Sprintf("insert into %s.%s select 'cf','1','test','t', cast(IFNULL(_tidb_origin_ts, _tidb_commit_ts) as unsigned)+1 from test.t where id=1", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
 		var checkpointTS uint64
-		row := tk.MustQuery(fmt.Sprintf("select min(checkpoint_ts) from %s.%s where database_name='test' and table_name='t'", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable)).Rows()
+		row := tk.MustQuery(fmt.Sprintf("select min(checkpoint_ts) from %s.%s where database_name='test' and table_name='t'", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable)).Rows()
 		checkpointTS, err := strconv.ParseUint(row[0][0].(string), 10, 64)
 		require.NoError(t, err)
 		run(t, pt, expire, checkpointTS, true, true)
 	})
 
 	t.Run("UpstreamTombstone", func(t *testing.T) {
-		tk.MustExec(fmt.Sprintf("delete from %s.%s", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
+		tk.MustExec(fmt.Sprintf("delete from %s.%s", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
 		tk.MustExec("use test")
 		tk.MustExec("drop table if exists t")
 		tk.MustExec("create table t(id int primary key, v int) active_active='on' softdelete retention 1 day softdelete_job_enable='ON'")
@@ -582,12 +582,12 @@ func TestActiveActiveSafetySQLExecutable(t *testing.T) {
 		expire := time.Now().UTC()
 
 		// No progress
-		tk.MustExec(fmt.Sprintf("insert into %s.%s values ('cf','1','test','t', 1)", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
+		tk.MustExec(fmt.Sprintf("insert into %s.%s values ('cf','1','test','t', 1)", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
 		run(t, pt, expire, 1, false, false)
 		// Deleted
-		tk.MustExec(fmt.Sprintf("delete from %s.%s", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
-		tk.MustExec(fmt.Sprintf("insert into %s.%s select 'cf','1','test','t', cast(IFNULL(_tidb_origin_ts, _tidb_commit_ts) as unsigned)+1 from test.t where id=1", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable))
-		row := tk.MustQuery(fmt.Sprintf("select min(checkpoint_ts) from %s.%s where database_name='test' and table_name='t'", sqlbuilder.TiCDCProgressDB, sqlbuilder.TiCDCProgressTable)).Rows()
+		tk.MustExec(fmt.Sprintf("delete from %s.%s", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
+		tk.MustExec(fmt.Sprintf("insert into %s.%s select 'cf','1','test','t', cast(IFNULL(_tidb_origin_ts, _tidb_commit_ts) as unsigned)+1 from test.t where id=1", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable))
+		row := tk.MustQuery(fmt.Sprintf("select min(checkpoint_ts) from %s.%s where database_name='test' and table_name='t'", mysql.TiCDCSystemDB, mysql.TiCDCProgressTable)).Rows()
 		checkpointTS, err := strconv.ParseUint(row[0][0].(string), 10, 64)
 		require.NoError(t, err)
 		run(t, pt, expire, checkpointTS, true, true)
diff --git a/pkg/ttl/ttlworker/softdelete_cleanup_job_integration_test.go b/pkg/ttl/ttlworker/softdelete_cleanup_job_integration_test.go
diff --git a/tests/integrationtest/r/ddl/active_active.result b/tests/integrationtest/r/ddl/active_active.result
diff --git a/tests/integrationtest/r/ddl/soft_delete.result b/tests/integrationtest/r/ddl/soft_delete.result
diff --git a/tests/integrationtest/r/softdelete/insert_on_duplicate.result b/tests/integrationtest/r/softdelete/insert_on_duplicate.result
diff --git a/tests/integrationtest/t/ddl/active_active.test b/tests/integrationtest/t/ddl/active_active.test
diff --git a/tests/integrationtest/t/ddl/soft_delete.test b/tests/integrationtest/t/ddl/soft_delete.test
diff --git a/tests/integrationtest/t/softdelete/insert_on_duplicate.test b/tests/integrationtest/t/softdelete/insert_on_duplicate.test

-Original file line number
+Diff line change
         "//br/pkg/version/build",
         "//pkg/config",
         "//pkg/meta/model",
 +        "//pkg/parser/mysql",
         "//pkg/session",
         "//pkg/util",
         "//pkg/util/gctuner",
Original file line number	Diff line number	Diff line change
`@@ -1396,7 +1396,8 @@ func RunStreamRestore(`
`1396`	`1396`	`}`
`1397`	`1397`	`// TODO: pitr filtered restore doesn't support restore system table yet`
`1398`	`1398`	`if cfg.ExplicitFilter {`
`1399`		`- if cfg.TableFilter.MatchSchema(mysql.SystemDB) \|\| cfg.TableFilter.MatchSchema(mysql.SysDB) {`
	`1399`	`+ if cfg.TableFilter.MatchSchema(mysql.SystemDB) \|\|`
	`1400`	`+ cfg.TableFilter.MatchSchema(mysql.SysDB) {`
`1400`	`1401`	`return errors.Annotatef(berrors.ErrInvalidArgument,`
`1401`	`1402`	`"PiTR doesn't support custom filter to include system db, consider to exclude system db")`
`1402`	`1403`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1575,7 +1575,7 @@ func (e executor) CreateView(ctx sessionctx.Context, s ast.CreateViewStmt) (er`
`1575`	`1575`	`tblCollate = v`
`1576`	`1576`	`}`
`1577`	`1577`
`1578`		`- tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, tblCharset, tblCollate)`
	`1578`	`+ tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, tblCharset, tblCollate, nil)`
`1579`	`1579`	`if err != nil {`
`1580`	`1580`	`return err`
`1581`	`1581`	`}`
`@@ -6104,7 +6104,7 @@ func (e executor) CreateSequence(ctx sessionctx.Context, stmt ast.CreateSequen`
`6104`	`6104`	`return err`
`6105`	`6105`	`}`
`6106`	`6106`	`// TiDB describe the sequence within a tableInfo, as a same-level object of a table and view.`
`6107`		`- tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), ident.Name, nil, nil, "", "")`
	`6107`	`+ tbInfo, err := BuildTableInfo(NewMetaBuildContextWithSctx(ctx), ident.Name, nil, nil, "", "", nil)`
`6108`	`6108`	`if err != nil {`
`6109`	`6109`	`return err`
`6110`	`6110`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ func MockTableInfo(sctx sessionctx.Context, stmt *ast.CreateTableStmt, tableID i`
`61`	`61`	`if err != nil {`
`62`	`62`	`return nil, errors.Trace(err)`
`63`	`63`	`}`
`64`		`- tbl, err := BuildTableInfo(ctx, stmt.Table.Name, cols, newConstraints, "", "")`
	`64`	`+ tbl, err := BuildTableInfo(ctx, stmt.Table.Name, cols, newConstraints, "", "", nil)`
`65`	`65`	`if err != nil {`
`66`	`66`	`return nil, errors.Trace(err)`
`67`	`67`	`}`
Original file line number	Diff line number	Diff line change
`@@ -276,7 +276,7 @@ func (d SchemaTracker) CreateView(ctx sessionctx.Context, s ast.CreateViewStmt`
`276`	`276`	`})`
`277`	`277`	`}`
`278`	`278`
`279`		`- tbInfo, err := ddl.BuildTableInfo(ddl.NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, "", "")`
	`279`	`+ tbInfo, err := ddl.BuildTableInfo(ddl.NewMetaBuildContextWithSctx(ctx), s.ViewName.Name, cols, nil, "", "", nil)`
`280`	`280`	`if err != nil {`
`281`	`281`	`return err`
`282`	`282`	`}`