PortManager (#234)

Main
- Old PortManager was deleted
- PostresNode uses new "abstract" interface PortManager to reserve/release port number.
- PostgresNode.free_port always resets port number
- OsOperations::is_free_port is added
- PostgresNode.start raises exception (InvalidOperationException) if node is None

Refactoring
- PostgresNode::port is RO-property now. It throws if port is None
- PostgresNode::host is RO-property now
- PostgresNode::ssh_key is RO-property now
- PostgresNode::name is RO-property now

Author: dmitry-lipetsk

Dockerfile--altlinux_10.tmpl

@@ -115,4 +115,4 @@ ssh-keygen -t rsa -f ~/.ssh/id_rsa -q -N ''; \
 cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys; \
 chmod 600 ~/.ssh/authorized_keys; \
 ls -la ~/.ssh/; \
-TEST_FILTER=\"TestTestgresLocal or TestOsOpsLocal or local_ops\" bash ./run_tests.sh;"
+TEST_FILTER=\"TestTestgresLocal or TestOsOpsLocal or local\" bash ./run_tests.sh;"

Dockerfile--altlinux_11.tmpl

@@ -115,4 +115,4 @@ ssh-keygen -t rsa -f ~/.ssh/id_rsa -q -N ''; \
 cat ~/.ssh/id_rsa.pub >> ~/.ssh/authorized_keys; \
 chmod 600 ~/.ssh/authorized_keys; \
 ls -la ~/.ssh/; \
-TEST_FILTER=\"TestTestgresLocal or TestOsOpsLocal or local_ops\" bash ./run_tests.sh;"
+TEST_FILTER=\"TestTestgresLocal or TestOsOpsLocal or local\" bash ./run_tests.sh;"

Dockerfile--ubuntu_24_04.tmpl

@@ -10,6 +10,7 @@ RUN apt install -y sudo curl ca-certificates
 RUN apt update
 RUN apt install -y openssh-server
 RUN apt install -y time
+RUN apt install -y netcat-traditional
 
 RUN apt update
 RUN apt install -y postgresql-common

run_tests.sh

@@ -5,7 +5,7 @@
 set -eux
 
 if [ -z ${TEST_FILTER+x} ]; \
-then export TEST_FILTER="TestTestgresLocal or (TestTestgresCommon and (not remote_ops))"; \
+then export TEST_FILTER="TestTestgresLocal or (TestTestgresCommon and (not remote))"; \
 fi
 
 # fail early

setup.py

@@ -29,7 +29,7 @@
 setup(
     version='1.10.5',
     name='testgres',
-    packages=['testgres', 'testgres.operations', 'testgres.helpers'],
+    packages=['testgres', 'testgres.operations'],
     description='Testing utility for PostgreSQL and its extensions',
     url='https://github.com/postgrespro/testgres',
     long_description=readme,

testgres/__init__.py

@@ -34,6 +34,7 @@
     DumpFormat
 
 from .node import PostgresNode, NodeApp
+from .node import PortManager
 
 from .utils import \
     reserve_port, \
@@ -53,8 +54,6 @@
 from .operations.local_ops import LocalOperations
 from .operations.remote_ops import RemoteOperations
 
-from .helpers.port_manager import PortManager
-
 __all__ = [
     "get_new_node",
     "get_remote_node",
@@ -64,7 +63,8 @@
     "TestgresException", "ExecUtilException", "QueryException", "TimeoutException", "CatchUpException", "StartNodeException", "InitNodeException", "BackupException", "InvalidOperationException",
     "XLogMethod", "IsolationLevel", "NodeStatus", "ProcessType", "DumpFormat",
     "PostgresNode", "NodeApp",
+    "PortManager",
     "reserve_port", "release_port", "bound_ports", "get_bin_path", "get_pg_config", "get_pg_version",
-    "First", "Any", "PortManager",
+    "First", "Any",
     "OsOperations", "LocalOperations", "RemoteOperations", "ConnectionParams"
 ]

testgres/exceptions.py

@@ -7,6 +7,10 @@ class TestgresException(Exception):
     pass
 
 
+class PortForException(TestgresException):
+    pass
+
+
 @six.python_2_unicode_compatible
 class ExecUtilException(TestgresException):
     def __init__(self, message=None, command=None, exit_code=0, out=None, error=None):