Remove duplicate set of print_notnull

alvherre · alvherre · commit f104192e52fe · 2025-04-03T17:34:25.000+02:00
I inserted the second one by mistake in commit 14e87ff. Reported-by: jian he <jian.universality@gmail.com> Confirmed-by: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> Discussion: https://postgr.es/m/CACJufxFqckBFxPfCixHHbOr0zMLksviTj2m3o12-tErfx_PvTg@mail.gmail.com
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -16681,11 +16681,6 @@ dumpTableSchema(Archive *fout, const TableInfo *tbinfo)
 											  tbinfo->attrdefs[j]->adef_expr);
 					}
 
-					print_notnull = (tbinfo->notnull_constrs[j] != NULL &&
-									 (tbinfo->notnull_islocal[j] ||
-									  dopt->binary_upgrade ||
-									  tbinfo->ispartition));
-
 					if (print_notnull)
 					{
 						if (tbinfo->notnull_constrs[j][0] == '\0')

Original file line number	Diff line number	Diff line change
`@@ -16681,11 +16681,6 @@ dumpTableSchema(Archive fout, const TableInfo tbinfo)`
`16681`	`16681`	`tbinfo->attrdefs[j]->adef_expr);`
`16682`	`16682`	`}`
`16683`	`16683`
`16684`		`- print_notnull = (tbinfo->notnull_constrs[j] != NULL &&`
`16685`		`- (tbinfo->notnull_islocal[j] \|\|`
`16686`		`- dopt->binary_upgrade \|\|`
`16687`		`- tbinfo->ispartition));`
`16688`		`-`
`16689`	`16684`	`if (print_notnull)`
`16690`	`16685`	`{`
`16691`	`16686`	`if (tbinfo->notnull_constrs[j][0] == '\0')`