From eceea8dacfac7ad42fb16ea6ee34de4aeba20bcd Mon Sep 17 00:00:00 2001
From: Commitfest Bot <cfbot@cputube.org>
Date: Wed, 30 Apr 2025 14:54:23 +0000
Subject: [PATCH] [PATCH]: ./postpone_string_buffer_creation_dblink.patch

---
 contrib/dblink/dblink.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 1b2d72c6def3..a7c1b42e23ae 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -2875,15 +2875,12 @@ get_connect_string(const char *servername)
 	ForeignServer *foreign_server = NULL;
 	UserMapping *user_mapping;
 	ListCell   *cell;
-	StringInfoData buf;
 	ForeignDataWrapper *fdw;
 	AclResult	aclresult;
 	char	   *srvname;
 
 	static const PQconninfoOption *options = NULL;
 
-	initStringInfo(&buf);
-
 	/*
 	 * Get list of valid libpq options.
 	 *
@@ -2908,6 +2905,7 @@ get_connect_string(const char *servername)
 
 	if (foreign_server)
 	{
+		StringInfoData buf;
 		Oid			serverid = foreign_server->serverid;
 		Oid			fdwid = foreign_server->fdwid;
 		Oid			userid = GetUserId();
@@ -2920,6 +2918,8 @@ get_connect_string(const char *servername)
 		if (aclresult != ACLCHECK_OK)
 			aclcheck_error(aclresult, OBJECT_FOREIGN_SERVER, foreign_server->servername);
 
+		initStringInfo(&buf);
+
 		/*
 		 * First append hardcoded options needed for SCRAM pass-through, so if
 		 * the user overwrites these options we can ereport on