-
-
Notifications
You must be signed in to change notification settings - Fork 58
/
Copy pathwith_scope_test.rb
567 lines (463 loc) · 15.1 KB
/
with_scope_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
# frozen_string_literal: true
require_relative "test_helper"
module SyntaxTree
class WithScopeTest < Minitest::Test
class Collector < Visitor
prepend WithScope
attr_reader :arguments, :variables
def initialize
@arguments = {}
@variables = {}
end
def self.collect(source)
new.tap { SyntaxTree.parse(source).accept(_1) }
end
visit_methods do
def visit_ident(node)
value = node.value.delete_suffix(":")
local = current_scope.find_local(node.value)
case local&.type
when :argument
arguments[[current_scope.id, value]] = local
when :variable
variables[[current_scope.id, value]] = local
end
end
def visit_label(node)
value = node.value.delete_suffix(":")
local = current_scope.find_local(value)
if local&.type == :argument
arguments[[current_scope.id, value]] = node
end
end
def visit_vcall(node)
local = current_scope.find_local(node.value)
variables[[current_scope.id, value]] = local if local
super
end
end
end
def test_collecting_simple_variables
collector = Collector.collect(<<~RUBY)
def foo
a = 1
a
end
RUBY
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [2], usages: [3])
end
def test_collecting_aref_variables
collector = Collector.collect(<<~RUBY)
def foo
a = []
a[1]
end
RUBY
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [2], usages: [3])
end
def test_collecting_multi_assign_variables
collector = Collector.collect(<<~RUBY)
def foo
a, b = [1, 2]
puts a
puts b
end
RUBY
assert_equal(2, collector.variables.length)
assert_variable(collector, "a", definitions: [2], usages: [3])
assert_variable(collector, "b", definitions: [2], usages: [4])
end
def test_collecting_pattern_matching_variables
collector = Collector.collect(<<~RUBY)
def foo
case [1, 2]
in Integer => a, Integer
puts a
end
end
RUBY
# There are two occurrences, one on line 3 for pinning and one on line 4
# for reference
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [3], usages: [4])
end
def test_collecting_pinned_variables
collector = Collector.collect(<<~RUBY)
def foo
a = 18
case [1, 2]
in ^a, *rest
puts a
puts rest
end
end
RUBY
assert_equal(2, collector.variables.length)
assert_variable(collector, "a", definitions: [2], usages: [4, 5])
assert_variable(collector, "rest", definitions: [4], usages: [6])
end
if RUBY_VERSION >= "3.1"
def test_collecting_one_line_pattern_matching_variables
collector = Collector.collect(<<~RUBY)
def foo
[1] => a
puts a
end
RUBY
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [2], usages: [3])
end
def test_collecting_endless_method_arguments
collector = Collector.collect(<<~RUBY)
def foo(a) = puts a
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "a", definitions: [1], usages: [1])
end
end
def test_collecting_method_arguments
collector = Collector.collect(<<~RUBY)
def foo(a)
puts a
end
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "a", definitions: [1], usages: [2])
end
def test_collecting_methods_with_destructured_post_arguments
collector = Collector.collect(<<~RUBY)
def foo(optional = 1, (bin, bag))
end
RUBY
assert_equal(3, collector.arguments.length)
assert_argument(collector, "optional", definitions: [1], usages: [])
assert_argument(collector, "bin", definitions: [1], usages: [])
assert_argument(collector, "bag", definitions: [1], usages: [])
end
def test_collecting_methods_with_desctructured_post_using_splat
collector = Collector.collect(<<~RUBY)
def foo(optional = 1, (bin, bag, *))
end
RUBY
assert_equal(3, collector.arguments.length)
assert_argument(collector, "optional", definitions: [1], usages: [])
assert_argument(collector, "bin", definitions: [1], usages: [])
assert_argument(collector, "bag", definitions: [1], usages: [])
end
def test_collecting_methods_with_nested_desctructured
collector = Collector.collect(<<~RUBY)
def foo(optional = 1, (bin, (bag)))
end
RUBY
assert_equal(3, collector.arguments.length)
assert_argument(collector, "optional", definitions: [1], usages: [])
assert_argument(collector, "bin", definitions: [1], usages: [])
assert_argument(collector, "bag", definitions: [1], usages: [])
end
def test_collecting_singleton_method_arguments
collector = Collector.collect(<<~RUBY)
def self.foo(a)
puts a
end
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "a", definitions: [1], usages: [2])
end
def test_collecting_method_arguments_all_types
collector = Collector.collect(<<~RUBY)
def foo(a, b = 1, *c, d, e: 1, **f, &block)
puts a
puts b
puts c
puts d
puts e
puts f
block.call
end
RUBY
assert_equal(7, collector.arguments.length)
assert_argument(collector, "a", definitions: [1], usages: [2])
assert_argument(collector, "b", definitions: [1], usages: [3])
assert_argument(collector, "c", definitions: [1], usages: [4])
assert_argument(collector, "d", definitions: [1], usages: [5])
assert_argument(collector, "e", definitions: [1], usages: [6])
assert_argument(collector, "f", definitions: [1], usages: [7])
assert_argument(collector, "block", definitions: [1], usages: [8])
end
def test_collecting_block_arguments
collector = Collector.collect(<<~RUBY)
def foo
[].each do |i|
puts i
end
end
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "i", definitions: [2], usages: [3])
end
def test_collecting_destructured_block_arguments
collector = Collector.collect(<<~RUBY)
[].each do |(a, *b)|
end
RUBY
assert_equal(2, collector.arguments.length)
assert_argument(collector, "b", definitions: [1])
end
def test_collecting_anonymous_destructured_block_arguments
collector = Collector.collect(<<~RUBY)
[].each do |(a, *)|
end
RUBY
assert_equal(1, collector.arguments.length)
end
def test_collecting_one_line_block_arguments
collector = Collector.collect(<<~RUBY)
def foo
[].each { |i| puts i }
end
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "i", definitions: [2], usages: [2])
end
def test_collecting_shadowed_block_arguments
collector = Collector.collect(<<~RUBY)
def foo
i = "something"
[].each do |i|
puts i
end
i
end
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "i", definitions: [4], usages: [5])
assert_equal(1, collector.variables.length)
assert_variable(collector, "i", definitions: [2], usages: [8])
end
def test_collecting_shadowed_local_variables
collector = Collector.collect(<<~RUBY)
def foo(a)
puts a
a = 123
a
end
RUBY
# All occurrences are considered arguments, despite overriding the
# argument value
assert_equal(1, collector.arguments.length)
assert_equal(0, collector.variables.length)
assert_argument(collector, "a", definitions: [1, 3], usages: [2, 4])
end
def test_variables_in_the_top_level
collector = Collector.collect(<<~RUBY)
a = 123
a
RUBY
assert_equal(0, collector.arguments.length)
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [1], usages: [2])
end
def test_aref_field
collector = Collector.collect(<<~RUBY)
object = {}
object["name"] = "something"
RUBY
assert_equal(0, collector.arguments.length)
assert_equal(1, collector.variables.length)
assert_variable(collector, "object", definitions: [1], usages: [2])
end
def test_aref_on_a_method_call
collector = Collector.collect(<<~RUBY)
object = MyObject.new
object.attributes["name"] = "something"
RUBY
assert_equal(0, collector.arguments.length)
assert_equal(1, collector.variables.length)
assert_variable(collector, "object", definitions: [1], usages: [2])
end
def test_aref_with_two_accesses
collector = Collector.collect(<<~RUBY)
object = MyObject.new
object["first"]["second"] ||= []
RUBY
assert_equal(0, collector.arguments.length)
assert_equal(1, collector.variables.length)
assert_variable(collector, "object", definitions: [1], usages: [2])
end
def test_aref_on_a_method_call_with_arguments
collector = Collector.collect(<<~RUBY)
object = MyObject.new
object.instance_variable_get(:@attributes)[:something] = :other_thing
RUBY
assert_equal(0, collector.arguments.length)
assert_equal(1, collector.variables.length)
assert_variable(collector, "object", definitions: [1], usages: [2])
end
def test_double_aref_on_method_call
collector = Collector.collect(<<~RUBY)
object = MyObject.new
object["attributes"].find { |a| a["field"] == "expected" }["value"] = "changed"
RUBY
assert_equal(1, collector.arguments.length)
assert_argument(collector, "a", definitions: [2], usages: [2])
assert_equal(1, collector.variables.length)
assert_variable(collector, "object", definitions: [1], usages: [2])
end
def test_nested_arguments
collector = Collector.collect(<<~RUBY)
[[1, [2, 3]]].each do |one, (two, three)|
one
two
three
end
RUBY
assert_equal(3, collector.arguments.length)
assert_equal(0, collector.variables.length)
assert_argument(collector, "one", definitions: [1], usages: [2])
assert_argument(collector, "two", definitions: [1], usages: [3])
assert_argument(collector, "three", definitions: [1], usages: [4])
end
def test_double_nested_arguments
collector = Collector.collect(<<~RUBY)
[[1, [2, 3]]].each do |one, (two, (three, four))|
one
two
three
four
end
RUBY
assert_equal(4, collector.arguments.length)
assert_equal(0, collector.variables.length)
assert_argument(collector, "one", definitions: [1], usages: [2])
assert_argument(collector, "two", definitions: [1], usages: [3])
assert_argument(collector, "three", definitions: [1], usages: [4])
assert_argument(collector, "four", definitions: [1], usages: [5])
end
def test_block_locals
collector = Collector.collect(<<~RUBY)
[].each do |; a|
end
RUBY
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [1])
end
def test_lambda_locals
collector = Collector.collect(<<~RUBY)
->(;a) { }
RUBY
assert_equal(1, collector.variables.length)
assert_variable(collector, "a", definitions: [1])
end
def test_regex_named_capture_groups
collector = Collector.collect(<<~RUBY)
if /(?<one>\\w+)-(?<two>\\w+)/ =~ "something-else"
one
two
end
RUBY
assert_equal(2, collector.variables.length)
assert_variable(collector, "one", definitions: [1], usages: [2])
assert_variable(collector, "two", definitions: [1], usages: [3])
end
def test_multiline_regex_named_capture_groups
collector = Collector.collect(<<~RUBY)
if %r{
(?<one>\\w+)-
(?<two>\\w+)
} =~ "something-else"
one
two
end
RUBY
assert_equal(2, collector.variables.length)
assert_variable(collector, "one", definitions: [2], usages: [5])
assert_variable(collector, "two", definitions: [3], usages: [6])
end
class Resolver < Visitor
prepend WithScope
attr_reader :locals
def initialize
@locals = []
end
visit_methods do
def visit_assign(node)
super.tap do
level = 0
name = node.target.value.value
scope = current_scope
while !scope.locals.key?(name) && !scope.parent.nil?
level += 1
scope = scope.parent
end
locals << [name, level]
end
end
end
end
def test_resolver
source = <<~RUBY
module Level0
level0 = 0
class Level1
level1 = 1
def level2
level2 = 2
tap do |level3|
level2 = 2
level3 = 3
tap do |level4|
level2 = 2
level4 = 4
end
end
end
end
end
RUBY
resolver = Resolver.new
SyntaxTree.parse(source).accept(resolver)
expected = [
["level0", 0],
["level1", 0],
["level2", 0],
["level2", 1],
["level3", 0],
["level2", 2],
["level4", 0]
]
assert_equal expected, resolver.locals
end
private
def assert_collected(field, name, definitions: [], usages: [])
keys = field.keys.select { |key| key[1] == name }
assert_equal(1, keys.length)
variable = field[keys.first]
assert_equal(definitions.length, variable.definitions.length)
definitions.each_with_index do |definition, index|
assert_equal(definition, variable.definitions[index].start_line)
end
assert_equal(usages.length, variable.usages.length)
usages.each_with_index do |usage, index|
assert_equal(usage, variable.usages[index].start_line)
end
end
def assert_argument(collector, name, definitions: [], usages: [])
assert_collected(
collector.arguments,
name,
definitions: definitions,
usages: usages
)
end
def assert_variable(collector, name, definitions: [], usages: [])
assert_collected(
collector.variables,
name,
definitions: definitions,
usages: usages
)
end
end
end