Skip to content

Fix #12964 - false positive with into_iter_without_iter #13030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

astra90x
Copy link
Contributor

@astra90x astra90x commented Jul 2, 2024

changelog: FP: into_iter_without_iter: No longer lints when the iter or iter_mut implementation is not within the first impl block

fixes #12964


I'm pretty new to this open-source thing, so hopefully I did everything right. Got a little annoyed this false positive was happening in my code and the issue was inactive for two weeks so I thought I'd fix it myself.

As an aside, maybe iter.map(...).next() could be linted against? I don't see that ever being preferred over iter.next().map(...), and it could've prevented the bug here.

@rustbot
Copy link
Collaborator

rustbot commented Jul 2, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Alexendoo (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 2, 2024
@Alexendoo
Copy link
Member

Thanks for the fix! Yeah you did everything right

As an aside, maybe iter.map(...).next() could be linted against? I don't see that ever being preferred over iter.next().map(...), and it could've prevented the bug here.

Could be a good one, it would make it clearer that it's only happening to the first item

@bors r+

@bors
Copy link
Contributor

bors commented Jul 2, 2024

📌 Commit 0dd8b27 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jul 2, 2024

⌛ Testing commit 0dd8b27 with merge 6e6683b...

@bors
Copy link
Contributor

bors commented Jul 2, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 6e6683b to master...

@bors bors merged commit 6e6683b into rust-lang:master Jul 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

into_iter_without_iter warns when code blocks are in particular order
4 participants