The function all() returns 10 documents by default

[andryw]

The function all() returns 10 documents by default. Should it return all documents?

[rochacbruno]

Elasticsearch has a default size of 10, There is no way to perform an unlimited search, one form is to get the count and use the from: 0 to: count but for large collections E.S can trow overflow error.

One solution is to use the scan method which gets all documents paginated, so .all() would be a paginated by default function.

I don't know which solution is the best.

@ederfmartins what do you think?

[ederfmartins]

Set size = 'count' put a infection into code, since it breaks for large
collections. I think all() should use scan. But this solution add a new
constraint on es parameter (it must implement scan).

elasticsearch.helpers.scan is a simple function. Integrate it into esengine
code seems a good trade of. What you think @rochacbruno
https://github.com/rochacbruno?

On Mon, Mar 21, 2016 at 10:58 AM, Bruno Rocha notifications@github.com
wrote:

Elasticsearch has a default size of 10, There is no way to perform an
unlimited search, one form is to get the count and use the from: 0 to:
count but for large collections E.S can trow overflow error.

One solution is to use the scan method which gets all documents
paginated, so .all() would be a paginated by default function.

I don't know which solution is the best.

@ederfmartins https://github.com/ederfmartins what do you think?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#20 (comment)