Skip to content

LSP client name is hardcoded #25

@OlivierNicole

Description

@OlivierNicole

Hi,
Thanks for a great plugin!

I couldn’t use it at the start because the function get_server looks for a client named ocamllsp, and in my config I called mine ocaml_ocamllsp. I suggest to have a config option to be able to set this name to something else.

This was fixed for me with this commit, but it’s only replacing the hardcoded string by another one.

Another thing: when it failed, it did print “Cannot find LSP server”, but then did try to use the returned result at this line, causing a Lua error and stack trace. It should probably stop after printing the error—though, in this case, the stack trace did help me find the problem quickly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions