Skip to content

Commit 2517c80

Browse files
authored
docs: migration guide had outdated instructions (oblador#1697)
1 parent c4295a0 commit 2517c80

File tree

2 files changed

+8
-17
lines changed

2 files changed

+8
-17
lines changed

MIGRATION.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,11 @@ The FontAwesome 5 and 6 fonts now take an `iconStlye` prop instead of a style na
4747
Note: The codemod assumes you used the naming from the old README for your component e.g. FontAwesome5 etc or Icon
4848
If you have imported the component with another name you will need to modify the codemod or make the changes yourself.
4949

50-
### Remove fonts from Info.plist (supported by codemod)
50+
### Remove unused fonts from Info.plist (supported by codemod)
5151

52-
Fonts are now automatically loaded on iOS, so you can remove any fonts you have listed in `Info.plist`
52+
You still need to add fonts here but should limit it to the fonts you have installed.
53+
54+
Check the [React Native Setup](./docs/SETUP-REACT-NATIVE.md) instructions for instructions on how update it with our included script.
5355

5456

5557
### iOS

docs/SETUP-REACT-NATIVE.md

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,16 @@
22

33
> If you use Expo, please follow [this guide](./SETUP-EXPO.md) instead. This guide applies to vanilla React Native apps only.
44
5+
56
### Android
67

78
1. Rebuild your app. No extra steps needed for Android.
89

910
### iOS
1011

12+
> [!TIP]
13+
> You will need to follow these instructions any time you add a new font
14+
1115
1. To use the icon packages you previously installed on iOS, run:
1216

1317
```sh
@@ -22,25 +26,10 @@ npx rnvi-update-plist package.json ios/AppName/Info.plist
2226
```xml
2327
<key>UIAppFonts</key>
2428
<array>
25-
<string>AntDesign.ttf</string>
26-
<string>Entypo.ttf</string>
27-
<string>EvilIcons.ttf</string>
28-
<string>Feather.ttf</string>
29-
<string>FontAwesome.ttf</string>
30-
<string>FontAwesome5_Brands.ttf</string>
31-
<string>FontAwesome5_Regular.ttf</string>
32-
<string>FontAwesome5_Solid.ttf</string>
3329
<string>FontAwesome6_Brands.ttf</string>
3430
<string>FontAwesome6_Regular.ttf</string>
3531
<string>FontAwesome6_Solid.ttf</string>
36-
<string>Fontisto.ttf</string>
37-
<string>Foundation.ttf</string>
38-
<string>Ionicons.ttf</string>
39-
<string>MaterialDesignIcons.ttf</string>
40-
<string>MaterialIcons.ttf</string>
4132
<string>Octicons.ttf</string>
42-
<string>SimpleLineIcons.ttf</string>
43-
<string>Zocial.ttf</string>
4433
</array>
4534
```
4635
</details>

0 commit comments

Comments
 (0)