Repository navigation
Conversation
twm
requested changes
Mar 14, 2020
Member
There was a problem hiding this comment.
Hi @graingert, thank you for this! However I don't think it's complete enough to merge yet:
- Please add a test that verifies unicode text is encoded as UTF-8.
- Since this adds support for
bytesusername and password, please add a test of that too. - Please update the documentation to reflect these changes. Specifically, mention the supported types in the docstring of
treq.request()(insrc/treq/api.py), and update the reference to RFC 2617 in the docs to RFC 7617.
Thanks again!
Member
|
Hi @graingert, gentle poke — do you plan to follow up here? |
Member
Author
|
@twm sorry I don't have time to finish this |
twm
added a commit
to twm/treq
that referenced
this pull request
Dec 26, 2020
Also accept bytes to allow user control over encoding. Closes twisted#268.
twm
added a commit
to twm/treq
that referenced
this pull request
Dec 26, 2020
Also accept bytes to allow user control over encoding. Closes twisted#268.
Merged
Member
Author
|
thanks @twm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://tools.ietf.org/html/rfc7617 and https://stackoverflow.com/a/7243567/833093 and https://www.fxsitecompat.dev/en-CA/docs/2018/basic-auth-credentials-are-now-encoded-in-utf-8-instead-of-iso-8859-1/