Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vuejs/vue-router
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dev
Choose a base ref
...
head repository: vuejs/vue-router
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fix/2606/poll-leak
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 7 files changed
  • 2 contributors

Commits on Sep 24, 2019

  1. fix(ssr): Memory leak in poll method, take 2 (fix #2606)

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    bd71f46 View commit details
    Browse the repository at this point in the history

  2. fix: cb called before data init in keep-alive view and mixin guards n… 

    …ot being called
    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    b19a1d8 View commit details
    Browse the repository at this point in the history

  3. refactor: renamed things for clarity

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    1891608 View commit details
    Browse the repository at this point in the history

  4. fix: fixed bug from refactoring

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    2b06f8d View commit details
    Browse the repository at this point in the history

  5. refactor: a little bit more refactoring

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    c2b0696 View commit details
    Browse the repository at this point in the history

  6. fix: fixed enter cb not called in out-in transitions still

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    d337f18 View commit details
    Browse the repository at this point in the history

  7. chore(test): added coverage for out-in transition before route enter cb

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    593e3c4 View commit details
    Browse the repository at this point in the history

  8. fix: lint

    @ronald-d-rogers @posva
    ronald-d-rogers authored and posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    50bf165 View commit details
    Browse the repository at this point in the history

  9. refactor: use one single component

    @posva
    posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    48d4f5d View commit details
    Browse the repository at this point in the history

  10. refactor: add back the isBeingDestroyed check

    @posva
    posva committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    36feb33 View commit details
    Browse the repository at this point in the history
Loading