-
Notifications
You must be signed in to change notification settings - Fork 3k
Implement dialog initial focus proposal #8199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
2394e21
Implement dialog initial focus proposal
josepharhar fd9c31d
add missing text from the proposal
josepharhar b52e9b6
add example
josepharhar 8da9666
add second example
josepharhar 2070d76
DialogShowOptions
josepharhar 50c821f
Add showmodal autofocus logic
josepharhar 844c49f
Merge remote-tracking branch 'upstream/main' into dialogsequentialfocus
josepharhar c15e1fc
remove a sentence with should
josepharhar 4727fc0
link to methods
josepharhar 8ff0298
dialogshowoptions
josepharhar da545c2
code input
josepharhar 7003f1f
non-normative -> normative
josepharhar 1ca7cbb
remove space
josepharhar 7dae27e
add links to element types and attributes
josepharhar 5907549
more normativeness
josepharhar b09e68c
dialog focusing steps link
josepharhar 136592c
dialogshowoptions -> options
josepharhar 1f0a278
preventinitialfocus stuff
josepharhar c6de43e
more preventinitialfocus linking
josepharhar e4046aa
remove explicit is modal parameter
josepharhar f60b5e2
more method
josepharhar 3f56f1f
Merge with some upstream commits
josepharhar 000aea4
respond to comments
josepharhar 30683ac
make dialog element focusable sort of
josepharhar c95c97b
some nits
josepharhar 133d817
Merge branch 'main' into dialogsequentialfocus
domenic 76ed03e
annevk nits
josepharhar 572a1c8
Merge branch 'main' into dialogsequentialfocus
josepharhar 7585ed6
replace product number with add product
josepharhar 9fe975a
remove extra space
josepharhar ca5d8e9
add pointer-events:none
josepharhar 1763b9c
Revert "add pointer-events:none"
josepharhar ee1a835
Merge branch 'main' into dialogsequentialfocus
josepharhar b9c63ca
remove modeless note
josepharhar 494d638
Revert "replace product number with add product"
josepharhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'main' into dialogsequentialfocus
- Loading branch information
commit 133d817071844ec72007fe50e2d03a9894ab9d9b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.