LGTM, thank you for investigating intermittents, Julian!

Thank you Julian, looks good

Thank you Dave for working on this!

R+

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Thank you for quick patch, Julian!

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Sorry for the delay, fell off my radar.
@jdescottes can you please look at this, thank you

@bomsy can you please look at this, thank you

Thank you Julian. The patch fixes the error appearing when the users clicks on a Browser Console link (I clicked on a warning coming from browser.xhtml)
Feels like a test is not needed for this minor change.

Thank you for STRs

Thank you for the patch.

@nchevobbe can you please help with the review when the patch is ready, thank you!

Nicolas, can you please help with the review here, thank you!

Two suggestions for description used in the tooltips

@nchevobbe can you please help with review here, thank you!

@jdescottes @can you please help with review here, thank you!

@nchevobbe can you please help with review here, thank you!

@bomsy assigning you for the review, thank you for the help.

Lookgs good.

Looks good, thank you Alex.

Looks good, than you Alex.

All make sense to me.

Looks good, thank you Alex.

Thank you Alex

Looks good, let's try to land this beast!

I went over all changes and didn't spot any typos or suspicious changes.
R+

Looks good to me, thank you Alex.

Sorry for the delay, I missed this review!

In D158016#5190423, @nchevobbe wrote:

Thanks Honza

I wonder if we could use a non breaking space between the keys for a given shortcut so we don't get such thing:

Fix block quote

Resolving review comments

Do not make changes in third_party/rust/fluent-testing/resources/browser/en-US/browser/browser.ftl

Change also string ID

Not sure why the binaries weren't uploaded properly, but I managed to upload it using moz-phab (instead of arc)
Unfortunately it created a new revision D157783

Text updated

One more fix related to Arrow keys styling

Fix table column widths for Eyedropper

Better fix for arrow keys styling

Beter table columns widths + fixing arrow keys styling

Fix typo

Try looks good

Thank you for updating the patch!

I am still seeing a failure when running the test in --verify mode

@bomsy @ochameau what is blocking us from enabling the test?

Thank you for the updates!

LGTM

@Eugene thank you for working on this!

Thank you Julian.

Thank you Mark for working on this!

Test-exception-other: jsut a pref flip, tests are implemented as part of different bugs.

Thank you Julian for fixing this follow up, looks good.

R+, thank you Julian.

Hi Tom, as I mentioned at the meeting I am not owner neither familier with this code base, sorry about that.

Thank you Julian. R+

Restested just now (both tests) and works well on my machine, thank you!

I tried to remove the added condition mimeType === "application/ogg" again and the test is still passing?
Did you try it on your machine before submitting?

Thank you Julian for working on intermittents, let's see if selecting the node first helps to stabilize it.
Honza

Thank you for the patch!

Thank you Bomsy.

Works for me now, thank you, Mike.
Tested on Nightly and Win10
The test is also green locally

Thank you for the investigation, Julian!

Thank you for the patch Mike!