User Details
- User Since
- Feb 4 2020, 12:13 PM (309 w, 2 d)
- Availability
- Available
- Review Queue
- 0
Yesterday
Thanks @jdescottes. Lgtm. The fix covers the issue.
Mon, Jan 5
Mon, Dec 22
Sun, Dec 21
Fri, Dec 19
@nchevobbe The summary hints to another patch on the stack. Is that no longer the case anymore? is this now a standalone patch?
Thu, Dec 18
Wed, Dec 17
Thanks @nchevobbe for the work to use a better api.
LGTM!
Tue, Dec 16
lgtm! Thanks
Thanks for the reviews Nicholas!
The only goal of this patch is to see the request in the netmonitor. The response panel is going to be empty because we do not receive datagram packets yet (That is future work planned)
The empty event listeners are going to useful when we start showing datagram packets in the response panel. For example the webTransportSessionClosed will be used to show when the connection is closed in the Response panel.
Also, the type column says "plain" for the 60344 request, should it says "webtransport" ?
That is the same thing we show for websocket requests, in the future we will look into improving that. (I’ll file something for that)
Also this doesn't have a test for the netmonitor, is this because the limitation of mochitests regarding TLS ? (I think you mentioned this a few times)
In such case it would be nice to mention this limitation in the commit message, and have a bug somewhere to add a mochitest, blocking it on adding support for TLS in mochitests
Yes this is because of the limitation of mochitests, i'll detail it in the description and link to the bug.