Thanks!

Looks good to me. I don't want to block in the suggestions since we're near the soft freeze.

Please also add that test-case :)

Yeah I guess bug 1945451 made this unnecessary.

testing-exception-other: system integration

In D274400#9492623, @Standard8 wrote:

Actually, one thought, should we delete rust-analyzer.server.extraEnv from existing installations?

rebase

Yeah shitty connection, thanks!

eslint

In D274369#9491680, @sickl8 wrote:

tested with https://bug1918733.bmoattachments.org/attachment.cgi?id=9424708 but I guess we need a formal test?

lints

Looks good with that, but needs a test?

Looks great, thank you!

In D274349#9491222, @dshin wrote:

In D274349#9491034, @emilio wrote:

It'd be good to add an automated test for this?

I do have some testcases, it's just a bit awkward because I had to add some (What feels like) arbitrary rAFs, to presumably bypass initial load content paint (I imagine this is why we happen to be passing a lot of scroll tests), which seems finicky. Is there a well documented way to bypass this?

Yeah the static pos behavior here is just wrong. The ancestor's border-padding just happens to work in this test-case but is not the right thing to offset stuff around.

(Mostly so you see the question above, I think this is fairly close)

It'd be good to add an automated test for this?

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

In D274281#9489074, @gstoll wrote:

Thanks so much for this!

Since I'm away from home right now I can't reproduce the original issue even without this patch, but with this patch I did play around with the usual stuff that would break with things I tried and it all seems fine.

If you're able to reproduce the original problem, could you try a few things on that monitor?

• With the titlebar on (i.e. tabs not in the titlebar), starting from a regular-sized window go fullscreen with F11 then press F11 again to go back. (I think I was running into some assertions at some point)
• With the titlebar off (i.e. tabs in the titlebar, the default), maximize the window, then go fullscreen with F11, then press F11 again to go back. With one of my fixes this would make the bottom of the window separate from the taskbar and so it wouldn't be maximized anymore.

testing-exception-other: hard to test window events

rebase

rebase

In D274128#9488644, @sickl8 wrote:

@emilio I tested it and it doesn't propagate, but I just tested with Chromium (brave) and it looks like they do support unitless regardless if it's <value> or calc(<value>), should I extend the support in the shorthand to handle it too?

Looks good with that, thanks!

It seems we also need to fix property_database.js: https://searchfox.org/firefox-main/rev/f81fae7890605739dd8dde14755f159fe6beb8aa/layout/style/test/property_database.js#11594-11600

Ok, I think this is the wrong approach. What's happening is that the SDK is handing NCCALCSIZE and that's messing up with our client area computations. D274281 is a better fix, I think.

@gstoll can you give me some steps to reproduce this? I want to poke a bit and see if we can come up with a less growss solution.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Looks great! https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=165928 is a try run.

This revision requires a Testing Policy Project Tag to be set before landing. Please apply one of testing-approved, testing-exception-unchanged, testing-exception-ui, testing-exception-elsewhere, testing-exception-other. Tip: this Firefox add-on makes it easy!

Can you abandon this change (at the bottom of the page, in the dropdown)?

rebase

rebase

rebase

rebase

No, it needs to be more complicated, but also more tests pass with that: https://hg-edge.mozilla.org/try/rev/c12cca7dadfc5b588a36247c4a07b41253e275fd is the patch we got to this morning. @tlouw can you udpate the revision? Or should I submit it as a separate rev?

Huh, so somehow I did update it?

Thanks! code-wise looks fine, but we need some tests. Can you test:

r=me with nits addressed. Thanks!

Looks really good, just one question on BindToTree, I'm not sure why that'd be needed.

This fixes test-cases with the patch from the blocked bug.

Yeah we have coverage for this. I remember trying to remove this in the past and it turning the tree orange.