Could we cover this with an additional mochitest assertion in one of the sources tests?

nah, i think it's fine.

I could have easily missed this, but is there a unit test for a source updating and the new toUpdate logic working?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce6709e3982ce96cbf78878d01aaeeebce596b12

thanks for the feedback. and sorry for the ping. I am pushing quite aggressively as i sort out the test failures

Great job

I filed a couple of follow up bugs:

the test leaks, but otherwise everything else is green
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6317d675ea53cc94a4bf147b548c2520ec8a0eff

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f309465b9a007c6221dea09ae8f277489e753aaf

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da79b0d7c7dbb589e2d9f987ecb271f92dae1f9a

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bcc88a91e33d45bafba130af948bf3e339ef6d0

Oy vey.

So... We can always call sources.reset() from the thread actor reconfigure method, but i'd rather not if we don't need to.

Oy vey.

i doubt it

https://treeherder.mozilla.org/#/jobs?repo=try&revision=59ee0773f092e694926d9f11551421e291205ba0

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e51c710915ca623c5d5b9c32208a758ca70116e2

Seeing two issues on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21c93b3259fb29a3c1d8eee7a1496d3af0279f63

Hey @jaril, I jumped in and addressed most, if not all, of the feedback. I didn't commandeer the patch though, so lets play it by ear in the next couple of days.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=071174fe7072e1bedb59097fdbbe7e1702a3362e

Looking good

Nice work

Good call

This brings getLineText down to 15ms from 40ms
https://profiler.firefox.com/public/3d500e89ad24feca59e63bbaa00f679e67d07c6c/stack-chart/?globalTrackOrder=8-0-1-2-3-4-5-6-7&hiddenGlobalTracks=1-2-3-4-5-6&hiddenLocalTracksByPid=36782-1-3-4-5-6~36793-0~36834-0&implementation=js&localTrackOrderByPid=36782-7-8-0-1-2-3-4-5-6~36785-0~36791-0~36787-0~36846-0~36867-0~36793-1-0~36834-1-2-0~&range=2.7024_4.2231&search=getText&showUserTimings&thread=0&v=4