feat: support V5 ListConsumerGroups protocol #3292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
reviewed
Sep 16, 2025
Signed-off-by: beanz <[email protected]>
Co-authored-by: Cassondra Foesch <[email protected]> Signed-off-by: Mark Hindess <[email protected]>
b608467 to
9c24841
Compare
66cfa09 to
6467f43
Compare
Signed-off-by: Dominic Evans <[email protected]>
6467f43 to
c847496
Compare
dnwe
approved these changes
Sep 17, 2025
Collaborator
dnwe
left a comment
There was a problem hiding this comment.
Thanks LGTM, I'll add a note to the description that we don't currently expose either the existing StatesFilter nor the new TypesFilter fields in the admin client call ((ca *clusterAdmin) ListConsumerGroups()). A user can send them manually via the broker's ListGroups func, but we should think how we can expose them on the admin client without breaking compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TypesFilter to request and GroupType to group data in the protocol. These come from KIP-848
Note: the option to specify these on a request is not currently exposed via
(ca *clusterAdmin) ListConsumerGroups()