Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dominikh/go-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2017.2.1
Choose a base ref
...
head repository: dominikh/go-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2017.2.2
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Jan 10, 2018

  1. unused: mark Lock method on NoCopy sentinel as used 

    When using `-exported`, the Lock method won't automatically be marked as
used, which led to the method being flagged as unused. Explicitly mark
it as used by the NoCopy sentinel type.
    @dominikh
    dominikh committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    c2bd6ce View commit details
    Browse the repository at this point in the history

  2. keyify: don't assume that file is in first package 

    Due to external tests, there can be two packages in one directory. We
have to find the correct package based on the provided file name.
    @dominikh
    dominikh committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    1267d35 View commit details
    Browse the repository at this point in the history

  3. keyify: ensure we found a file 

    A race condition could remove the file between invocation of keyify and
loading the package.
    @dominikh
    dominikh committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    74d83c9 View commit details
    Browse the repository at this point in the history

  4. staticcheck: remove SA4005 

    SA4005 (ineffective field assignments) is buggy and causing false
positives. We will reimplement it in the future.
    @dominikh
    dominikh committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    9778aca View commit details
    Browse the repository at this point in the history

  5. Version 2017.2.2

    @dominikh
    dominikh committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    d73ab98 View commit details
    Browse the repository at this point in the history
Loading