-
Notifications
You must be signed in to change notification settings - Fork 50.2k
[Flight] Never parse "then" functions #35289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comparing: f99241b...69c9cb7 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
gnoff
approved these changes
Dec 5, 2025
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 7, 2025
AFAIK this is not needed to prevent any exploit but we don't really need this. We allow functions on pretty much any other object anyway but never on the "then" property since those would be serialized as Promises by the client anyway. DiffTrain build for [3016ff8](facebook@3016ff8)
github-actions bot
pushed a commit
to code/lib-react
that referenced
this pull request
Dec 7, 2025
AFAIK this is not needed to prevent any exploit but we don't really need this. We allow functions on pretty much any other object anyway but never on the "then" property since those would be serialized as Promises by the client anyway. DiffTrain build for [3016ff8](facebook@3016ff8)
This was referenced Dec 11, 2025
ch4og
pushed a commit
to csmplay/mapban
that referenced
this pull request
Dec 23, 2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [react](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react)) | [`19.2.1` -> `19.2.3`](https://renovatebot.com/diffs/npm/react/19.2.1/19.2.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [react-dom](https://react.dev/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react-dom)) | [`19.2.1` -> `19.2.3`](https://renovatebot.com/diffs/npm/react-dom/19.2.1/19.2.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>facebook/react (react)</summary> ### [`v19.2.3`](https://github.com/facebook/react/releases/tag/v19.2.3): 19.2.3 (December 11th, 2025) [Compare Source](facebook/react@v19.2.2...v19.2.3) ##### React Server Components - Add extra loop protection to React Server Functions ([@​sebmarkbage](https://github.com/sebmarkbage) [#​35351](facebook/react#35351)) ### [`v19.2.2`](https://github.com/facebook/react/releases/tag/v19.2.2): 19.2.2 (December 11th, 2025) [Compare Source](facebook/react@v19.2.1...v19.2.2) ##### React Server Components - Move `react-server-dom-webpack/*.unbundled` to private `react-server-dom-unbundled` ([@​eps1lon](https://github.com/eps1lon) [#​35290](facebook/react#35290)) - Patch Promise cycles and toString on Server Functions ([@​sebmarkbage](https://github.com/sebmarkbage), [@​unstubbable](https://github.com/unstubbable) [#​35289](facebook/react#35289), [#​35345](facebook/react#35345)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi4xNC4yIiwidXBkYXRlZEluVmVyIjoiNDIuMTQuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.csmpro.ru/csmpro/mapban/pulls/75 Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK this is not needed to prevent any exploit but we don't really need this. We allow functions on pretty much any other object anyway but never on the "then" property since those would be serialized as Promises by the client anyway.