Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: golang/go
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: go1.25.4
Choose a base ref
...
head repository: golang/go
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: go1.25.5
Choose a head ref
  • 5 commits
  • 8 files changed
  • 5 contributors

Commits on Nov 25, 2025

  1. [release-branch.go1.25] internal/syscall/windows: fix ReOpenFile sent…

    …inel error value
    
    ReOpenFile is documented to return INVALID_HANDLE_VALUE on error,
    but the previous definition was checking for 0 instead.
    
    ReOpenFile was added to the go1.25 release branch in CL 715360. This new CL amends it.
    
    Fixes #76360
    Updates #75989
    
    Change-Id: Idec5e75e40b9f6c409e068d63a9b606781e80a46
    Reviewed-on: https://go-review.googlesource.com/c/go/+/717320
    Auto-Submit: Quim Muntal <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-by: Alex Brainman <[email protected]>
    Reviewed-by: Michael Pratt <[email protected]>
    (cherry picked from commit CL 717320)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/718000
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    qmuntal authored and cherrymui committed Nov 25, 2025
    Configuration menu
    Copy the full SHA
    433c01e View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.25] mime: parse media types that contain braces

    This CL fixes a bug introduced by CL 666655: isTokenChar would no longer
    (but should) report true for '{' and '}'.
    
    Fixes #76245
    
    Change-Id: Ifc0953c30d7cae7bfba9bc4b6bb6951a83c52576
    GitHub-Last-Rev: c91a75c
    GitHub-Pull-Request: #76243
    Reviewed-on: https://go-review.googlesource.com/c/go/+/719380
    Reviewed-by: Sean Liao <[email protected]>
    Reviewed-by: Jorropo <[email protected]>
    Reviewed-by: Michael Knyszek <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    (cherry picked from commit c761b26)
    Reviewed-on: https://go-review.googlesource.com/c/go/+/721000
    Reviewed-by: Junyang Shao <[email protected]>
    jub0bs authored and cherrymui committed Nov 25, 2025
    Configuration menu
    Copy the full SHA
    e1ce1bf View commit details
    Browse the repository at this point in the history
  3. [release-branch.go1.25] crypto/x509: excluded subdomain constraints p…

    …reclude wildcard SANs
    
    When evaluating name constraints in a certificate chain, the presence of
    an excluded subdomain constraint (e.g., excluding "test.example.com")
    should preclude the use of a wildcard SAN (e.g., "*.example.com").
    
    Fixes #76442
    Fixes #76464
    Fixes CVE-2025-61727
    
    Change-Id: I42a0da010cb36d2ec9d1239ae3f61cf25eb78bba
    Reviewed-on: https://go-review.googlesource.com/c/go/+/724400
    Reviewed-by: Nicholas Husin <[email protected]>
    Reviewed-by: Nicholas Husin <[email protected]>
    Reviewed-by: Daniel McCarney <[email protected]>
    LUCI-TryBot-Result: Go LUCI <[email protected]>
    Reviewed-by: Neal Patel <[email protected]>
    rolandshoemaker authored and cherrymui committed Nov 25, 2025
    Configuration menu
    Copy the full SHA
    287017a View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2025

  1. [release-branch.go1.25] crypto/x509: prevent HostnameError.Error() fr…

    …om consuming excessive resource
    
    Constructing HostnameError.Error() takes O(N^2) runtime due to using a
    string concatenation in a loop. Additionally, there is no limit on how
    many names are included in the error message. As a result, a malicious
    attacker could craft a certificate with an infinite amount of names to
    unfairly consume resource.
    
    To remediate this, we will now use strings.Builder to construct the
    error message, preventing O(N^2) runtime. When a certificate has 100 or
    more names, we will also not print each name individually.
    
    Thanks to Philippe Antoine (Catena cyber) for reporting this issue.
    
    Updates #76445
    Fixes #76461
    Fixes CVE-2025-61729
    
    Change-Id: I6343776ec3289577abc76dad71766c491c1a7c81
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3000
    Reviewed-by: Neal Patel <[email protected]>
    Reviewed-by: Damien Neil <[email protected]>
    Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3200
    Reviewed-by: Roland Shoemaker <[email protected]>
    Reviewed-on: https://go-review.googlesource.com/c/go/+/725800
    TryBot-Bypass: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Mark Freeman <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Auto-Submit: Dmitri Shuralyov <[email protected]>
    nicholashusin authored and gopherbot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    f7bce4b View commit details
    Browse the repository at this point in the history
  2. [release-branch.go1.25] go1.25.5

    Change-Id: If484d63fd8cc5ea0872780019535368afcf4ec5b
    Reviewed-on: https://go-review.googlesource.com/c/go/+/725842
    Auto-Submit: Gopher Robot <[email protected]>
    Reviewed-by: Dmitri Shuralyov <[email protected]>
    Reviewed-by: Mark Freeman <[email protected]>
    TryBot-Bypass: Gopher Robot <[email protected]>
    gopherbot committed Dec 2, 2025
    Configuration menu
    Copy the full SHA
    fefb02a View commit details
    Browse the repository at this point in the history
Loading