-
Notifications
You must be signed in to change notification settings - Fork 5
feat(dialogs): allow to quickly show a dialog #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
+ Coverage 43.33% 49.93% +6.60%
==========================================
Files 22 22
Lines 773 803 +30
Branches 93 102 +9
==========================================
+ Hits 335 401 +66
+ Misses 437 401 -36
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b9065f2 to
17da271
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
17da271 to
86e8589
Compare
|
rebased |
CarlSchwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but maybe wait for another review :)
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy enough! Super clean!
|
Confirm dialogs seem to me to be a part of UI Kit. Why add them here and not in |
I think the general idea behind this package was / is to have a framework agnostic library as replacement of legacy OCP and OC API. |
Often its quite useful to just spin up a very simple dialog without need of using the builder.
(had this floating around for some time, so added tests now and created this PR :) ).